Analyzer incorrectly resolves unqualified identifiers in classes

[leafpetersen]

In the following example:

final int x = 3;

class A {
  int x = 3;
}

class B extends A {
  void test() {
    x = 4;
  }
}

The specification requires that the reference to x resolve to the top level definition of x, for which no setter is defined, and hence should be a static error.

Evaluation of an assignment $a$ of the form \code{$v$ = $e$}
proceeds as follows:
%% TODO(eernst): $d$ is defined ambiguously: both getter & setter may exist.
Let $d$ be the innermost declaration whose name is $v$ or \code{$v$=}, if it exists.
It is a compile-time error if $d$ denotes
a prefix object, type declaration, or function declaration.

The CFE resolves this correctly, so there is an inconsistency between the tools. See this comment for more discussion.

See also:

• Analyzer incorrectly resolves assignments to extension method setters which shadow toplevel symbols #37925
• Analyzer incorrectly resolves assignment to an instance setter which shadows a toplevel method #37923

cc @stereotype441 @vsmenon @Markzipan

[eernstg]

Also note that the imprecision which is noted in places like the 'TODO' comment above is addressed in dart-lang/language#548, which is currently under review.

[srawlins]

Analyzer now produces:

'x' can't be used as a setter because it's final.