-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Description
For example, API_TIMELINE_DURATION in dart_api_impl.cc
DART_EXPORT Dart_Handle Dart_Invoke(Dart_Handle target,
Dart_Handle name,
int number_of_arguments,
Dart_Handle* arguments) {
DARTSCOPE(Thread::Current());
API_TIMELINE_DURATION(T);
...
}
(https://github.com/flutter/engine/pull/14323/files) this PR make API stream events available to systrace. but only can record TimeBeginEndScope, not including TimelineDurationScope.
with this PR, Dart_Invoke event can support in systrace

so I choose to replace all uses of TimelineDurationScope with TimeBeginEndScope, and remove unnecessary code to prevent future use of TimelineDurationScope method.
Metadata
Metadata
Assignees
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.