Skip to content

support vm events available to systrace #39757

@yuanhuihui

Description

@yuanhuihui

For example, API_TIMELINE_DURATION in dart_api_impl.cc

DART_EXPORT Dart_Handle Dart_Invoke(Dart_Handle target,
                                    Dart_Handle name,
                                    int number_of_arguments,
                                    Dart_Handle* arguments) {
  DARTSCOPE(Thread::Current());
  API_TIMELINE_DURATION(T);
  ...
}

(https://github.com/flutter/engine/pull/14323/files) this PR make API stream events available to systrace. but only can record TimeBeginEndScope, not including TimelineDurationScope.

with this PR, Dart_Invoke event can support in systrace
5-2-systrace-opt-all的副本

so I choose to replace all uses of TimelineDurationScope with TimeBeginEndScope, and remove unnecessary code to prevent future use of TimelineDurationScope method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions