Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frog doesn't report error/warning if returning value from void function #404

Closed
DartBot opened this issue Nov 9, 2011 · 4 comments
Closed

frog doesn't report error/warning if returning value from void function #404

DartBot opened this issue Nov 9, 2011 · 4 comments
Assignees
@jmesserly

Comments

@DartBot
Copy link

DartBot commented Nov 9, 2011

This issue was originally filed by mattsh@google.com

void foo() {
  return 6;
}

gives no errors or warnings in frog.
@DartBot
Copy link
Author

DartBot commented Nov 11, 2011

This comment was originally written by drfibonacci@google.com

Added Area-Frog, Triaged labels.

@jmesserly
Copy link

This appears to be fixed (at least, if "foo" is called):

/Users/jmesserly/scratch/test.dart:2:10: warning: type "int" is not assignable to "void"
  return 6;

I suspect this bug predates our checking of return types.

Added Fixed label.

@DartBot
Copy link
Author

DartBot commented Dec 1, 2011

This comment was originally written by mattsh@google.com

Yes, works great now.

@DartBot
Copy link
Author

DartBot commented Dec 1, 2011

This comment was originally written by mattsh@google.com

Added Verified label.

nex3 pushed a commit that referenced this issue Aug 31, 2016
@vsmenon
Fixes #408
e907ebb 
This is a bug on JSON.decode.  This should match the hand fix in #404.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1579223002 .
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmesserly jmesserly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmesserly @DartBot