Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vm] Handle late fields in type propagation #40796

Closed
liamappelbe opened this issue Feb 26, 2020 · 1 comment
Closed

[vm] Handle late fields in type propagation #40796

liamappelbe opened this issue Feb 26, 2020 · 1 comment
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release

Comments

@liamappelbe
Copy link
Contributor

Currently we're just setting late fields to nullable in the type propagator, because otherwise all the sentinel comparison logic gets optimised out. This works, but is not optimal.

We'll need to extend CompileType to be able to handle lateness.

@liamappelbe liamappelbe added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release labels Feb 26, 2020
@mraleph
Copy link
Member

mraleph commented Feb 27, 2020

I don't think you should extend CompileType for this purpose. I suggest instead look at unifying late field lowering and InitStaticField and then either write a specialized data flow pass which removes redundant Init* instructions (if we want to handle complicated cases) or just permit CSE to remove Init* by dominance.

@alexmarkov alexmarkov self-assigned this Apr 9, 2020
dart-bot pushed a commit that referenced this issue Apr 15, 2020
Issue: #41299
Issue: #41417
Issue: #40796
Change-Id: Ibcc0ea55c6262ccafdda6c3fb1b28f357297c1de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143100
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
Benchmark: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release
Projects
None yet
Development

No branches or pull requests

3 participants