Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vm/ffi] Clean up dealing with tearoffs of asFunction/lookupFunction #42260

Closed
dcharkes opened this issue Jun 10, 2020 · 0 comments
Closed

[vm/ffi] Clean up dealing with tearoffs of asFunction/lookupFunction #42260

dcharkes opened this issue Jun 10, 2020 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi

Comments

@dcharkes
Copy link
Contributor

The tearoffs of asFunction and lookupFunction contain a generic call to their respective definitions. This triggers our extra checks that we do not have generic calls to these extension methods. To Work around this we've been excluding dart:ffi call sites. However, we do have other call sites in dart:ffi which could be checked.

The cleaner solution would be to exclude the bodies of those specific tearoffs, instead of all code in dart:ffi.
@dcharkes dcharkes added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi labels Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcharkes