Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick dart-lang/sdk@ac4de98 to stable branch #43013

Closed
a-siva opened this issue Aug 11, 2020 · 4 comments
Closed

cherry pick dart-lang/sdk@ac4de98 to stable branch #43013

a-siva opened this issue Aug 11, 2020 · 4 comments
Assignees
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@a-siva
Copy link
Contributor

a-siva commented Aug 11, 2020

commit(s) to merge: ac4de98

merge instructions: The change does not merge cleanly, please see
https://dart-review.googlesource.com/c/sdk/+/158102 for a patch CL

What is the issue: Applications run into the following unhandled exception
Unsupported operation: serialization of generic DartType: UnknownType(?) (UnknownType)

What is the fix: CFE Eliminates UnknownType in async type downcasts

Why cherrypick: A number of flutter users (almost 21 upvotes for the issue) have run into this issue, please see
flutter/flutter#63038

Risk: The fix landed in the Dart tree on Jul 14th and has been rolled into bleeding edge Flutter. It has been in the
bleeding edge branch for over 3 weeks now and the risk is pretty low.
Number of lines of code change 2 and there is a CFE unit test case for the change.

Link to original issue(s):
Flutter : flutter/flutter#63038
Dart : #42615

@a-siva a-siva added the cherry-pick-review Issue that need cherry pick triage to approve label Aug 11, 2020
@a-siva
Copy link
Contributor Author

a-siva commented Aug 11, 2020

@johnniwinther
Copy link
Member

lgtm

@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Aug 11, 2020
@franklinyow
Copy link
Contributor

Approved in SCRUM
@pcsosinski @athomas

@a-siva a-siva added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label Aug 11, 2020
dart-bot pushed a commit that referenced this issue Aug 12, 2020
Cherry Pick CL for #42615

Closes #43013.

Bug: #42615
Change-Id: Ieb289acee04b3868304d320d3c2231fd6eb94dd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154322
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
@pcsosinski
Copy link

fixed in 2.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Development

No branches or pull requests

5 participants