Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the versioning of Dart SDK packages #4352

Closed
nex3 opened this issue Aug 3, 2012 · 6 comments
Closed

Fix the versioning of Dart SDK packages #4352

nex3 opened this issue Aug 3, 2012 · 6 comments
Assignees
Milestone

Comments

@nex3
Copy link
Member

nex3 commented Aug 3, 2012

We used to use the /revision file in the Dart SDK to determine the version of the packages contained within, but that file has apparently disappeared. We should generate the version from the timestamp on the /create.stamp file instead.

@devoncarew
Copy link
Member

I still see this file as existing in the latest continuous builds (http://gsdview.appspot.com/dart-editor-archive-continuous/latest/). What archive is it missing from?

@sethladd
Copy link
Contributor

sethladd commented Aug 3, 2012

I made a local build, straight from source, using ./tool/build.py -m release The output dir, xcodebuild/ReleaseIA32/dart-sdk is what I point DART_SDK to.

I suspect our build process only uses "svn info", and it should use "git svn info" if "svn info" isn't working.

@munificent
Copy link
Member

Added this to the M1 milestone.

@nex3
Copy link
Member Author

nex3 commented Sep 5, 2012

I'm building from Git, and I have a revision file in my SDK output.

@sethladd
Copy link
Contributor

Build script generates a revision file for both svn and git now.


Added Fixed label.

@nex3 nex3 self-assigned this Sep 13, 2012
@nex3 nex3 added this to the M1 milestone Sep 13, 2012
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#57.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants