Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the versioning of Dart SDK packages #57

Closed
DartBot opened this issue Jun 5, 2015 · 5 comments
Closed

Fix the versioning of Dart SDK packages #57

DartBot opened this issue Jun 5, 2015 · 5 comments
Assignees
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="96" height="96"hspace="10"> Issue by nex3
Originally opened as dart-lang/sdk#4352


We used to use the /revision file in the Dart SDK to determine the version of the packages contained within, but that file has apparently disappeared. We should generate the version from the timestamp on the /create.stamp file instead.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/1269969?v=3" align="left" width="48" height="48"hspace="10"> Comment by devoncarew


I still see this file as existing in the latest continuous builds (http://gsdview.appspot.com/dart-editor-archive-continuous/latest/). What archive is it missing from?

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) Fixed labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


I made a local build, straight from source, using ./tool/build.py -m release The output dir, xcodebuild/ReleaseIA32/dart-sdk is what I point DART_SDK to.

I suspect our build process only uses "svn info", and it should use "git svn info" if "svn info" isn't working.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Added this to the M1 milestone.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


I'm building from Git, and I have a revision file in my SDK output.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


Build script generates a revision file for both svn and git now.


Added Fixed label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants