Separate TypeArguments into separate TypeParameters (binding) and TypeArguments (use) classes. #43901
Assignees
Labels
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Comments
sstrickl
added
the
area-vm
|
/cc @mkustermann @crelier |
|
@sstrickl Now that my CL introducing a proper |
|
No worries, I have other things to focus on at the moment, go for it! :) (Yaaaaaaay, separating binding and use!) |
|
Great! Thanks. I am on it. |
dart-bot
pushed a commit
that referenced
this issue
May 5, 2021
…n the VM." This reverts commit 8a21ab1. Reason for revert: Test failure: http://b/187227619 Original change's description: > [VM/runtime] Refactor the representation of type parameters in the VM. > > This introduces a new VM internal class 'TypeParameters' representing the declaration of a list of type parameters, either in a class or function. > The reference to (or use of) a type parameter is still represented by the existing 'TypeParameter' class. > > Fixes #43901 > Fixes #45763 > > TEST=existing ones and a regression test > > Change-Id: I1fde808bf753cc1cb829f2c4383c1836651cee80 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189942 > Commit-Queue: Régis Crelier <regis@google.com> > Reviewed-by: Alexander Markov <alexmarkov@google.com> TBR=rmacnak@google.com,alexmarkov@google.com,regis@google.com,sstrickl@google.com Change-Id: If12caa1a84cb6d1c1b8225589f3c994d25abb120 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198282 Reviewed-by: Michal Terepeta <michalt@google.com> Reviewed-by: Tess Strickland <sstrickl@google.com> Commit-Queue: Michal Terepeta <michalt@google.com>
dart-bot
pushed a commit
that referenced
this issue
May 5, 2021
…n the VM." This is a reland of 8a21ab1 Original change's description: > [VM/runtime] Refactor the representation of type parameters in the VM. > > This introduces a new VM internal class 'TypeParameters' representing the declaration of a list of type parameters, either in a class or function. > The reference to (or use of) a type parameter is still represented by the existing 'TypeParameter' class. > > Fixes #43901 > Fixes #45763 > > TEST=existing ones and a regression test > > Change-Id: I1fde808bf753cc1cb829f2c4383c1836651cee80 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189942 > Commit-Queue: Régis Crelier <regis@google.com> > Reviewed-by: Alexander Markov <alexmarkov@google.com> This fixes #45911 TEST=existing ones and a regression test Change-Id: I709d38b1df3d73fe3c9796d5aca3cbbdcf77fd38 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198380 Commit-Queue: Régis Crelier <regis@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In CL 168101, we save the default arguments (i.e., results of instantiating to bounds) calculated by the CFE in
TypeParameterobjects. However, these default arguments are only needed when the instantiator of aTypeArgumentsobject containing onlyTypeParameters has not provided any explicit type arguments, and won't be used when instantiating individualTypeParameters.Instead, we should separate out binding and use occurrences of
TypeArgumentsinto two classes,TypeParametersandTypeArguments. The former will replace the use of TypeArguments to store the type parameters of classes and functionss, and it can store a vector that represents the entire vector instantiated to bounds without adding overhead to allTypeArgumentsobjects. We can also move any methods onTypeArgumentsthat only make sense for binding positions to the newTypeParametersclass.The text was updated successfully, but these errors were encountered: