Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests to Expect #456

Closed
DartBot opened this issue Nov 15, 2011 · 3 comments
Closed

Add more tests to Expect #456

DartBot opened this issue Nov 15, 2011 · 3 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Nov 15, 2011

This issue was originally filed by domi...@google.com

Consider adding
  - Expect.isLessThan
  - Expect.isLessThanOrEquals
  - Expect.isGreaterThan
  - Expect.isGreaterThanOrEquals
@DartBot
Copy link
Author

DartBot commented Nov 15, 2011

This comment was originally written by drfibonacci@google.com

Removed Type-Defect label.
Added Type-Enhancement, Area-VM, Triaged labels.

@iposva-google
Copy link
Contributor

The class Expect is part of the corelib, over to Area-Library.

Removed Area-VM label.
Added Area-Library label.

@floitschG
Copy link
Contributor

Since we have unit-testing libraries now, users shouldn't use Expect anymore.
Expect will still be used in the language and corelib tests to make it easier to get tests running, but even then we are probably going to move it into a separate library (probably living in the tests-directory).

Added WontFix label.

@DartBot DartBot added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Dec 18, 2012
@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug and removed resolution-wont_fix labels Mar 1, 2016
nex3 pushed a commit that referenced this issue Aug 31, 2016
@vsmenon
Fix travis
a9bcaf6 
This also regens based on the latest analyzer.  Looks like most improvements on the code.

See #456

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/1710583002 .
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue Sep 21, 2022
@devoncarew
Bump markdown to 87e4c689342d5bbaa84ba2999abf0bff503979be
c63c74e 
Changes:
```
> git log --format="%C(auto) %h %s" 32a9450..87e4c68
 https://dart.googlesource.com/markdown.git/+/87e4c68 Bump to 6.0.1 (#462)
 https://dart.googlesource.com/markdown.git/+/37305cf Add deprecated accessors for indicatorForUncheckedCheckBox and indicatorForCheckedCheckBox (#459)
 https://dart.googlesource.com/markdown.git/+/2e5e347 lint cleanup (#456)
 https://dart.googlesource.com/markdown.git/+/a0b5a05 example: small tweak to example – add Dart code (#455)
 https://dart.googlesource.com/markdown.git/+/de32a69 visitText to use textContent getter so subclassing Text class works correctly. (#431)
 https://dart.googlesource.com/markdown.git/+/8247955 Rewrite checkbox(task list) extension (#450)
 https://dart.googlesource.com/markdown.git/+/a602760 Fix crash with mixed checkbox lists (#449)

```

Diff: https://dart.googlesource.com/markdown.git/+/32a94505ded3863b82310b86344a003a19c00341~..87e4c689342d5bbaa84ba2999abf0bff503979be/
Change-Id: I92cf05fe6057e1b3eda8da09fc4eac4f67dd47ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260441
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
@mmukagali mmukagali mentioned this issue Dec 2, 2022
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @iposva-google @floitschG @DartBot