[CP][stable channel] ec48e8f - DDC: Fix missing nullability from recursive type hierarchies

[nshahan]

commit(s) to merge: ec48e8f

merge instructions: clean merge

What is the issue: DDC uses a different code path when compiling mixins or extends clauses that lead to a circular reference of the class itself. That code path was losing nullability information (nullable, or legacy) of the types when they appear in those positions.

What is the fix: Stop ignoring the nullability and emit them properly in those code patterns.

Why cherrypick: This is a correctness issue, mostly noticeable when running in sound null safety mode. The bug has been present since we unforked the SDK but it was noticed and reported recently by an external Flutter Web user.

Risk: Low risk because the fix targets a code path that is only used by circular class hierarchies and then the hierarchy must include a nullable type for the change to make any difference.

Link to original issue(s): #45767

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @sigmundch

[sigmundch]

@leafpetersen - we are curious to hear your thoughts on the severity of the issue here.

I'm ambivalent this time around. I agree it's low risk and I'd have gone for it a couple weeks back, but given the higher bar for cherry-picking at this time, I'm inclined to wait for the next release and not cherry-pick.

[leafpetersen]

I'm still supportive of a cherry pick. The change is DDC only, so the risk is highly ring-fenced. The problem is somewhat esoteric, but it was found organically, and if I understand correctly this bug will be more likely to surface as apps turn on sound null safety.

[franklinyow]

CC: @kf6gpe

[kf6gpe]

Are we discussing this for Dart 2.13 beta? If so, the window opens again om the week of 5/21. Can we wait that long given the fact that it's an esoteric case? Or hotfix in Dart and pick it up in Flutter when we hotfix Flutter that week?

[franklinyow]

Discussed in SCURM meeting. This can wait until 5/12. We are approving this for 5/21 window

I will update the label and title in a later date.

[franklinyow]

Description:
Fix missing nullability from recursive type hierarchies, see #45767 for detail