Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/minidump.py crashes #46029

Closed
ghost opened this issue May 17, 2021 · 1 comment
Closed

tools/minidump.py crashes #46029

ghost opened this issue May 17, 2021 · 1 comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas).

Comments

@ghost
Copy link

ghost commented May 17, 2021

tools/minidump.py is crashing on Windows bots:

Archiving coredumps for crash (if possible):
----> Crash(vm/dart_2/unboxed_param_test: 7964 binary.release_x64_dart_precompiled_runtime.exe, binary.release_x64_kernel-service.dart.snapshot)
----> Crash(ffi_2/vmspecific_object_gc_test: 7792 binary.release_x64_dart_precompiled_runtime.exe, binary.release_x64_kernel-service.dart.snapshot)
ERROR: Failed to archive crashes: 'dict' object has no attribute 'iteritems'
Traceback (most recent call last):
  File "tools/test.py", line 57, in <module>
    sys.exit(Main())
[...]
  File "C:\b\s\w\ir\tools\minidump.py", line 108, in <module>
    Enum(ctypes.c_uint32, MINIDUMP_STREAM_TYPE)),
  File "C:\b\s\w\ir\tools\minidump.py", line 17, in __init__
    self.value2name = {v: k for k, v in name2value.iteritems()}
AttributeError: 'dict' object has no attribute 'iteritems'

log

This is due to the python2 dict.iteritems method being removed in python3.
@ghost ghost added area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). labels May 17, 2021
@ghost ghost self-assigned this May 17, 2021
@ghost
Copy link
Author

ghost commented May 17, 2021

I have made https://dart-review.googlesource.com/c/sdk/+/200184 to fix the issue.

dart-bot pushed a commit that referenced this issue May 17, 2021
[tool] Fixes crash in tools/minidump.py
9b16765 
Fixed by migrating to dict.items() which is available in both python2
and python3.

TEST=Manual testing in python2 and python3.

Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-win-release-x64-try
Bug: #46029
Change-Id: I1c8363dfc44dc39f2430f84c4f22631a2e7203cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200184
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
@ghost ghost closed this as completed May 17, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants