Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyzer does not populate generic metadata on typedef's aliased type #46064

Closed
jcollins-g opened this issue May 18, 2021 · 1 comment
Closed

analyzer does not populate generic metadata on typedef's aliased type #46064

jcollins-g opened this issue May 18, 2021 · 1 comment
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented May 18, 2021 •
edited
Loading

Maybe blocking dart-lang/dartdoc#2517.

Given an expression like this (with the experiment for generic_metadata enabled): https://github.com/dart-lang/dartdoc/blob/34d371f539e72880e1ff723be891fcd91502f450/testing/test_package_experiments/lib/generic_metadata.dart#L209

I would expect to see for the FunctionTypeImpl metadata populated for both the type parameter and the positional parameter associated with this type. However I do not see that with 1.5.0 analyzer or head analyzer as of this writing.

Screen Shot 2021-05-18 at 1 58 20 PM
@jcollins-g jcollins-g changed the title analyzer does not populate generic metadata on typedefs analyzer does not populate generic metadata on typedef's aliased type May 18, 2021
@jcollins-g jcollins-g added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label May 18, 2021
@jcollins-g jcollins-g mentioned this issue May 18, 2021
Merged
@scheglov scheglov self-assigned this May 19, 2021
@scheglov scheglov added the P3 A lower priority bug or feature request label May 19, 2021
@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/200564

dart-bot pushed a commit that referenced this issue May 19, 2021
@scheglov
Issue 46064. Support for metadata in aliased GenericFunctionType type…
a65aa7e 
… / formal parameters.

Bug: #46064
Change-Id: Ibfd8be2df3bc999706fccbaf69554a4d956cc4e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200564
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scheglov @jcollins-g