Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement constructor tearoffs support in language tests and in co19 tests #46242

Closed
2 tasks done
eernstg opened this issue Jun 3, 2021 · 3 comments
Closed
2 tasks done
Assignees
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@eernstg
Copy link
Member

eernstg commented Jun 3, 2021

This issue tracks support of the constructor tearoffs feature. See the enclosing meta-issue for details.

The work on these tests has started:

@eernstg eernstg added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Jun 3, 2021
@devoncarew devoncarew removed the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jun 14, 2021
@devoncarew
Copy link
Member

@eernstg - is this item done (or if not, who's the best owner?)?

@eernstg eernstg self-assigned this Aug 25, 2021
@eernstg
Copy link
Member Author

eernstg commented Aug 25, 2021

The co19 tests are here: https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Constructor-tear-offs.

I'm working on https://dart-review.googlesource.com/c/sdk/+/211140 which adds a test about constant factory contructors #46984, and I'm about to add a test about syntactic disambiguation, dart-lang/language#1806.

@lrhn, do you have any upcoming constructor-tearoffs tests? Current language tests are here:

typedef/aliased_type_literal_instantiation_test.dart
typedef/aliased_constructor_tear_off_test.dart
constructor/reference_test.dart
constructor/tear_off_test.dart
constructor/unnamed_new_error_test.dart
constructor/unnamed_new_test.dart
generic_methods/explicit_instantiated_tearoff_test.dart
type_object/explicit_instantiated_type_literal_error_test.dart
type_object/explicit_instantiated_type_literal_test.dart

So we're nearly done. I've assigned myself as owner.

@eernstg
Copy link
Member Author

eernstg commented Sep 3, 2021

No further proposals, so I'll close this one.

@eernstg eernstg closed this as completed Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Development

No branches or pull requests

2 participants