Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for constructor tearoffs #46228

Closed
19 of 20 tasks
eernstg opened this issue Jun 3, 2021 · 5 comments
Closed
19 of 20 tasks

Tracking issue for constructor tearoffs #46228

eernstg opened this issue Jun 3, 2021 · 5 comments
Assignees
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool) P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@eernstg
Copy link
Member

eernstg commented Jun 3, 2021

This issue tracks the implementation of the constructor tearoffs feature.

Prerequisite Tasks

Implementation Tasks

  • Issue for language tests written.
  • Issue for core library updates.
  • Issue for implementation in CFE.
  • Issue for implementation in DDC.
  • Issue for implementation in the VM.
  • Issue for implementation in Dartfmt.
  • Issue for implementation in build systems and Angular compiler.
  • Issue for VM Service support.
  • Issue for implementation in Dartdoc.
  • Issue for implementation in syntax highlighters
  • Issue for support in linter.
  • Issue for implementation in IntelliJ.
  • Issue for implementation in Cider.
  • Issue for tests validated as passing (this is managed via the constructor-tearoffs spreadsheet).
  • Issue for web debugging support.
  • Issue for implementation in dart2js.
  • Issue for implementation in Kythe.
  • Issue for implementation in Analyzer.
  • Issue for documentation.
@devoncarew devoncarew added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Jun 3, 2021
@jcollins-g
Copy link
Contributor

Added dart-lang/language#1663 and a reference here since many teams/individuals are using these bugs as a signal for when to start implementing as well as tracking issues once implementation begins -- feel free to move that around/correct wording if need be.

@lrhn
Copy link
Member

lrhn commented Jun 14, 2021

The proposal is accepted and available as a feature specification in the "accepted/" directory.

The experiment flag is called "constructor-tearoffs" even if there are other related features included.

@eernstg eernstg added the implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool) label Jul 29, 2021
@devoncarew
Copy link
Member

Note that the github project we're using to track this work is here: https://github.com/orgs/dart-lang/projects/27.

@eernstg
Copy link
Member Author

eernstg commented Aug 26, 2021

@stereotype441, I approved the test failures on language/constructor/explicit_instantiation_syntax_test.dart with a reference to this issue, because the parser is shared between the CFE and the analyzer (so it's a very global thing).

@devoncarew devoncarew added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Oct 14, 2021
@devoncarew
Copy link
Member

An update - all work here (modulo documentation) is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool) P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

4 participants