Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement constructor tearoffs support in IntelliJ #46234

Closed
eernstg opened this issue Jun 3, 2021 · 14 comments
Closed

Implement constructor tearoffs support in IntelliJ #46234

eernstg opened this issue Jun 3, 2021 · 14 comments
Assignees
Labels
area-intellij Tracking issues for the Dart IntelliJ plugin.

Comments

@eernstg
Copy link
Member

eernstg commented Jun 3, 2021

This issue tracks support of the constructor tearoffs feature. See the enclosing meta-issue for details.

@devoncarew devoncarew added the area-intellij Tracking issues for the Dart IntelliJ plugin. label Jun 3, 2021
@devoncarew
Copy link
Member

@eernstg - is the syntax finalized now (and ready for parsers to implement / syntax highlighters to be updated)?

cc @jwren

@eernstg
Copy link
Member Author

eernstg commented Jun 3, 2021

I think it's a good idea to wait, in order to avoid duplicated work in case there are changes in the design before it is accepted. We will add a comment here (and on all the other issues associated with #46228) at that time.

@jwren
Copy link
Member

jwren commented Jul 7, 2021

@eernstg - Devon mentioned that the syntax is finalized enough to add to the Dart Plugin for IntelliJ. The feature link above is broken, is this link the correct source of truth? Thank you -- Jaime

@eernstg
Copy link
Member Author

eernstg commented Jul 8, 2021

@jwren, thanks! Yes, the document was moved and the link you mentioned is the correct one today. Corrected it above, too.

@jwren
Copy link
Member

jwren commented Aug 11, 2021

Grammar changes required are here: https://dart-review.googlesource.com/c/sdk/+/197161

@jwren
Copy link
Member

jwren commented Aug 17, 2021

Initial PR to Alex out at JetBrains/intellij-plugins#819

@devoncarew
Copy link
Member

@jwren - I believe the support landed?

@alexander-doroshko
Copy link

@devoncarew Only part of it. Things like const filledIntList = List<int>.filled; are not supported yet. Also tracked as https://youtrack.jetbrains.com/issue/WEB-52293.

@devoncarew
Copy link
Member

Great, thanks for the update! FYI, depending on general readiness, we may or may not enable this in the beta release shipping the week of 9/13.

@devoncarew
Copy link
Member

Also related: #47160

@devoncarew
Copy link
Member

@jwren - can you confirm that this is generally on track for early October?

@jwren
Copy link
Member

jwren commented Sep 14, 2021

I have tried a few times to cover the last case (see above) without overhauling the BNF. @alexander-doroshko said he would try to take a look soon. To answer the question though, we'll figure it out in time for an early October release.

@alexander-doroshko
Copy link

Full syntax support is there in the latest published Dart plugin builds for all IDEs.

@devoncarew
Copy link
Member

Great - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-intellij Tracking issues for the Dart IntelliJ plugin.
Projects
None yet
Development

No branches or pull requests

4 participants