Dart constructor tearoff support. #819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -313,19 +313,19 @@ private functionNative ::= 'native' (stringLiteralExpression ';' | ';' | stringL | |||
|
|
|||
| methodDeclaration ::= metadata* ('external' | 'static' | 'const')* methodDeclarationPrivate initializers? (';' | functionBodyOrNative | redirection)? | |||
| {pin=3 mixin="com.jetbrains.lang.dart.psi.impl.AbstractDartMethodDeclarationImpl" implements="com.jetbrains.lang.dart.psi.DartComponent"} | |||
| private methodDeclarationPrivate ::= returnType <<methodNameWrapper>> typeParameters? formalParameterList | !untypedFunctionType <<methodNameWrapper>> typeParameters? formalParameterList // todo remove, use functionSignature as in spec | |||
| private methodDeclarationPrivate ::= returnType (<<methodNameWrapper>> | 'new') typeParameters? formalParameterList | !untypedFunctionType (<<methodNameWrapper>> | 'new') typeParameters? formalParameterList // todo remove, use functionSignature as in spec | |||
There was a problem hiding this comment.
It's suspicious that here's no '.' before 'new'. Are you sure this change is needed? Tests don't fail if I revert changes in this line.
There was a problem hiding this comment.
You are correct, the syntax for named constructors kicks in making this change unnecessary, reverting here.
|
Thanks for the PR. |
See ConstructorTearoffs.dart test, with the exception of the last expression, `var f2 = C<num>.new;` I have the Dart.bnf parser working with the new syntax.
jwren
force-pushed
the
constructor-tearoffs
branch
from
d45b1cd to
34b8b93
Compare
| @@ -313,19 +313,19 @@ private functionNative ::= 'native' (stringLiteralExpression ';' | ';' | stringL | |||
|
|
|||
| methodDeclaration ::= metadata* ('external' | 'static' | 'const')* methodDeclarationPrivate initializers? (';' | functionBodyOrNative | redirection)? | |||
| {pin=3 mixin="com.jetbrains.lang.dart.psi.impl.AbstractDartMethodDeclarationImpl" implements="com.jetbrains.lang.dart.psi.DartComponent"} | |||
| private methodDeclarationPrivate ::= returnType <<methodNameWrapper>> typeParameters? formalParameterList | !untypedFunctionType <<methodNameWrapper>> typeParameters? formalParameterList // todo remove, use functionSignature as in spec | |||
| private methodDeclarationPrivate ::= returnType <<methodNameWrapper>> typeParameters? formalParameterList | !untypedFunctionType (<<methodNameWrapper>> | 'new') typeParameters? formalParameterList // todo remove, use functionSignature as in spec | |||
There was a problem hiding this comment.
There were two 'new' additions in this line =). I removed the second one as well before merging.
|
Merged this wip. Tracking issue remains open: https://youtrack.jetbrains.com/issue/WEB-52293 |
SergeyZh
pushed a commit
that referenced
this pull request
Sep 17, 2021
close #819 (cherry picked from commit be32521dcccff3790fdc665e229931d998a9bae9) IJ-CR-14281 GitOrigin-RevId: 76dbdff591743a666ec4a4957e879b422ae60ae5
SergeyZh
pushed a commit
that referenced
this pull request
Sep 27, 2021
close #819 (cherry picked from commit be32521dcccff3790fdc665e229931d998a9bae9) IJ-CR-14281 GitOrigin-RevId: 4525761d9f441d1a786b669a99061fb77e4e59d4
SergeyZh
pushed a commit
that referenced
this pull request
Sep 28, 2021
close #819 (cherry picked from commit be32521dcccff3790fdc665e229931d998a9bae9) IJ-CR-14281 (cherry picked from commit 4525761d9f441d1a786b669a99061fb77e4e59d4) GitOrigin-RevId: c592eda34d32f0cfd9e89fa1da7069c7715cbf7d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ConstructorTearoffs.dart test, with the exception of the last expression,
var f2 = C<num>.new;I have the Dart.bnf parser working with the new syntax.@alexander-doroshko -- thanks for any insights to getting around the BNF parsing of this expression as a new expression or call expression instead of a compare expression.