-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables are not scoped within loops #468
Comments
Yeah, this is an issue with us not initializing things to null properly. Fix incoming. |
Added Fixed label. |
nex3
pushed a commit
that referenced
this issue
Aug 31, 2016
Run coverage, transformer and node tests in their own Travis env
This was referenced Oct 29, 2020
copybara-service bot
pushed a commit
that referenced
this issue
Oct 19, 2022
…_stack_trace, source_maps, see, stack_trace, test, webdev bazel_worker (https://github.com/dart-lang/bazel_worker/compare/9710de6..75a947f): 75a947f 2022-10-18 Nate Bosch Prepare to publish (#63) collection (https://github.com/dart-lang/collection/compare/ca45fc4..efd709f): efd709f 2022-10-18 Kevin Moore Fix doc comment references among other new lints (#253) markdown (https://github.com/dart-lang/markdown/compare/d72ae07..93d0eee): 93d0eee 2022-10-14 Kevin Moore Misc package cleanup, mostly lints (#468) 16781b6 2022-10-14 Kevin Moore CI: update actions, add dependabot (#469) pub_semver (https://github.com/dart-lang/pub_semver/compare/7671359..28159b8): 28159b8 2022-10-14 Devon Carew prep for publishing (#73) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/72dbf21..8d8078f): 8d8078f 2022-10-18 Devon Carew update ci; prep for publishing (#30) source_maps (https://github.com/dart-lang/source_maps/compare/e93565b..c7e8963): c7e8963 2022-10-18 Devon Carew adjust the min sdk we test against (#68) 4f0b1e2 2022-10-18 Devon Carew update ci; prep for publishing (#67) sse (https://github.com/dart-lang/sse/compare/00084c4..283568d): 283568d 2022-10-14 Devon Carew update ci; prep for publishing (#64) stack_trace (https://github.com/dart-lang/stack_trace/compare/9697e4c..dce0013): dce0013 2022-10-18 Kevin Moore fix changelog link test (https://github.com/dart-lang/test/compare/58beb14..f704d5a): f704d5af 2022-10-17 godofredoc Add scorecard badge to test repo. (#1774) webdev (https://github.com/dart-lang/webdev/compare/69aac60..5343edb): 5343edb 2022-10-17 Elliott Brooks (she/her) Migrate more files to null-safety (#1758) ce498c2 2022-10-14 Elliott Brooks (she/her) Migrate `configuration.dart` and `shared.dart` to null-safety (#1757) Change-Id: I8859b1abc22f630c2136a69b0ad5a836691b9dbd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264881 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Kevin Moore <kevmoo@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 20, 2022
bazel_worker (https://github.com/dart-lang/bazel_worker/compare/75a947f..03717ca): 03717ca 2022-10-19 Parker Lougheed Fix changelog mention of required SDK version (#64) html (https://github.com/dart-lang/html/compare/0740fc7..0bf6019): 0bf6019 2022-10-19 Devon Carew rev the package version in preparation for publishing (#190) markdown (https://github.com/dart-lang/markdown/compare/d72ae07..93d0eee): 93d0eee 2022-10-14 Kevin Moore Misc package cleanup, mostly lints (#468) 16781b6 2022-10-14 Kevin Moore CI: update actions, add dependabot (#469) source_maps (https://github.com/dart-lang/source_maps/compare/c7e8963..b031e2c): b031e2c 2022-10-19 Devon Carew Update README.md (#69) webdev (https://github.com/dart-lang/webdev/compare/5343edb..a02f073): a02f073 2022-10-19 Daco Harkes Support `--source` in `FrontendServerClient` (#1760) Change-Id: I16a0c8b2d6457874e3848a58f1e4fd1650a8d894 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265002 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Nate Bosch <nbosch@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A variable declared within a loop is not correctly scoped within that loop. Consider the following code:
main() {
for (var i = 0; i < 5; i++) {
var a;
if (a == null) a = 0;
a += 1;
print(a);
}
}
This should print 1 five times, since a should be local to each loop iteration. Instead, it prints 1 through 5. If a is explicitly initialized to null, it behaves correctly.
The text was updated successfully, but these errors were encountered: