Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend range async/await benchmarks to cover various scenarios #48594

Open
mkustermann opened this issue Mar 17, 2022 · 1 comment
Open

Extend range async/await benchmarks to cover various scenarios #48594

mkustermann opened this issue Mar 17, 2022 · 1 comment
Assignees
@alexmarkov
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request triaged Issue has been triaged by sub team

Comments

@mkustermann
Copy link
Member

mkustermann commented Mar 17, 2022 •
edited
Loading

We should expand benchmarking of async/async*/await code to cover more scenarios

  • running inside root zone vs custom error zone vs custom zone
  • running with many different return types of async functions (e.g. due to sdk/issues/48235)
  • running with few / many live variables across awaits

/cc @mraleph @alexmarkov
@mkustermann mkustermann added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Mar 17, 2022
@alexmarkov alexmarkov self-assigned this Mar 17, 2022
copybara-service bot pushed a commit that referenced this issue Mar 30, 2022
@alexmarkov
[benchmarks] Add micro-benchmark for async/await with live variables
b55dc76 
Issue: #48594
Issue: #48378
Change-Id: Ib5bd65c149342bb5d9bb2b5176a4a3b968a08a81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238980
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
@alexmarkov
Copy link
Contributor

@mraleph Also suggested to add benchmark for awaiting a custom Future implementation such as SynchronousFuture from Flutter.

@alexmarkov alexmarkov added P3 A lower priority bug or feature request triaged Issue has been triaged by sub team labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmarkov alexmarkov

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkustermann @alexmarkov