[Extension type] Analysis server / IDE support work

[itsjustkevin]

This is the issue tracking the work that needs to be done in the analysis server to support the views feature. If you decide to work on a feature, either create an issue for the feature and link to it from here, or put your name beside the feature so that we don't duplicate effort.

• Call Hierarchy (dantup)
• Closing Labels (N/A, scheglov)
• Code Completion (brianwilkerson)
• Code Folding (scheglov)
• documentSymbol (keertip)
• Flutter Outline (N/A, dantup)
• Hovers (keertip? bwilkerson?)
• Implemented Markers (scheglov)
• Navigation (scheglov)
• Occurrences (scheglov)
• Organize Imports (N/A, scheglov)
• Outline (keertip)
• Overrides Markers (scheglov)
• Quick Assists (keertip)
• Quick Fixes (keertip)
• Refactorings - legacy (scheglov)
• Refactorings - self describing (keertip)
• Search - Find References (scheglov)
• Search - Member Declarations (scheglov)
• Search - Member References (scheglov)
• Search - Top-level Declarations (scheglov)
• selectionRange (scheglov)
• Syntax Highlighting
  • Semantic Highlights (dantup)
  • LSP Semantic Tokens (dantup)
  • dart-syntax-highlight TextMate Grammar (dantup)
• Signature Help (dantup)
• Snippets (N/A dantup)
• Sort Members (scheglov)
• Type Hierarchy (scheglov)
• Type Hierarchy - LSP (dantup)

[srawlins]

Still blocked on dart-lang/language#2420

[DanTup]

@srawlins what's the status of this? I started some changes (dart-lang/dart-syntax-highlight#41, https://dart-review.googlesource.com/c/sdk/+/286928) because I had a notification from #49734 and the spec is in the "Accepted" folder, but I just noticed the comment above and that #2420 is still open :-)

[eernstg]

I hadn't noticed that dart-lang/language#2420 was open and referred to 'views'. The feature is now the 'inline class' feature, the spec is in accepted and dart-lang/language#2420 has been closed.

[eernstg]

I haven't changed the title of this issue (or any other issue on this topic area), because I did not want to create further confusion (e.g., suddenly they may not be searchable if they are searched using terms like 'views').

However, I think it would be helpful to replace every occurrence of 'view' such that it says 'inline class'.

[eernstg]

I added a comment on the '[views]' issues that I could easily find.

[DanTup]

Yeah, that caught me out too 😄 Maybe it's worth just adding Inline-Classes (and keeping Views) avoids any confusion?

I also now see I missed the milestone change above from Dart3 -> Future so guess that somewhat answers my question too.

[srawlins]

Hey @DanTup I was out today but it looks like all your questions are answered, haha. Yeah it's accepted and there is a lot of movement, e.g. in dart_style, parser, etc. So it is "accepted" for some "future" release.

[DanTup]

Snippets

Any opinion on whether we should add a snippet for extension type? We do have some snippets for basic things like class definition although we don't currently have one for extension. I don't personally feel like they add a lot, although perhaps they do help with the syntax if it's not something you type out by hand a lot?

[bwilkerson]

I don't have a strong opinion, although I agree that they generally feel like they don't add much. I'm fine with not having one, but don't object to having one if someone thinks we should.

[bwilkerson]

The feature has shipped, so I'm going to close this. Any features not yet implemented should have their own issues.