Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inline classes #41

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Conversation

DanTup
Copy link
Collaborator

@DanTup DanTup commented Mar 6, 2023

See dart-lang/sdk#49734 and https://github.com/dart-lang/language/blob/master/accepted/future-releases/inline-classes/feature-specification.md.

Inline is only detected as part of class, since the spec says:

The token inline is not made a built-in identifier: the reserved word class that occurs right after inline serves to disambiguate the inline class declaration with a fixed lookahead.

@kevmoo
Copy link
Member

kevmoo commented Mar 6, 2023

Thanks, @DanTup !

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@devoncarew
Copy link
Member

@DanTup - can you resolve the change conflict here? And, you now have write access to this repo, so will be able to merge your own PRs (after review).

@DanTup DanTup force-pushed the inline-classes branch from ff529eb to 32a6e52 Compare May 9, 2023 09:01
@DanTup
Copy link
Collaborator Author

DanTup commented May 9, 2023

@devoncarew thanks! I've rebased and updated the version/date. I presume it's reasonable to land this now even if inline classes may be a little way off (it's just the single keyword)?

@devoncarew
Copy link
Member

I presume it's reasonable to land this now even if inline classes may be a little way off (it's just the single keyword)?

Ah, good question. It may be better to hold off on that until more things start landing / we have a better sense of how far out it is.

@DanTup
Copy link
Collaborator Author

DanTup commented May 9, 2023

sgtm, I'll leave it here for now and update the version/date as appropriate when things might be clearer. Thanks!

@devoncarew devoncarew marked this pull request as draft May 10, 2023 22:29
DanTup added 4 commits June 28, 2023 13:12
See dart-lang/sdk#49734 and https://github.com/dart-lang/language/blob/master/accepted/future-releases/inline-classes/feature-specification.md.

Inline is only detected as part of class, the spec says:

> The token `inline` is not made a built-in identifier: the reserved word `class` that occurs right after `inline` serves to disambiguate the inline class declaration with a fixed lookahead.
@DanTup DanTup marked this pull request as ready for review June 28, 2023 12:14
@DanTup
Copy link
Collaborator Author

DanTup commented Jun 28, 2023

@devoncarew @jwren based on discussions it sounds like it's reasonable to merge this?

I've updated the date in changelog, though the version is still the same as nothing else has been committed since I first did this. Let me know if you've happy for me to merge (seems like I have merge access here now 👍).

@jwren
Copy link
Member

jwren commented Jun 28, 2023

Yes, do merge, if there are any other syntax changes we can always follow up.

@DanTup DanTup merged commit 4670ad8 into dart-lang:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants