Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CL "Add parser support for patternAssignment" introduces crashes in frontend test cases #50575

Closed
stereotype441 opened this issue Nov 29, 2022 · 2 comments
Closed

CL "Add parser support for patternAssignment" introduces crashes in frontend test cases #50575

stereotype441 opened this issue Nov 29, 2022 · 2 comments
Assignees
@johnniwinther
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. P2 A bug or feature request we're likely to work on

Comments

@stereotype441
Copy link
Member

In Add parser support for patternAssignment I'm adding status file entries to expect crashes in the following frontend tests:

extensions/explicit_invalid_access
general/issue40242
rasta/malformed_function

The crashes are happening because these tests contain code that was previously invalid, but is now being parsed as a pattern assignment, and pattern assignment support is not yet complete:

  • extensions/explicit_invalid_access contains Extension(c) = 42;
  • general/issue40242 contains (c2) = new C();
  • rasta/malformed_function contains (null) = null;.
@stereotype441 stereotype441 added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label Nov 29, 2022
@stereotype441
Copy link
Member Author

CC @johnniwinther @chloestefantsova

copybara-service bot pushed a commit that referenced this issue Nov 29, 2022
@stereotype441
Add parser support for patternAssignment.
7b41b62 
Bug: #50035, #50502, #50575
Change-Id: Idd3bdcae7cbb95c6f2016bb5d3efc638867f52af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272383
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
@johnniwinther
Copy link
Member

extensions/explicit_invalid_access and general/issue40242 no longer crashes.

@johnniwinther johnniwinther added the P2 A bug or feature request we're likely to work on label Jan 10, 2023
@johnniwinther johnniwinther self-assigned this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stereotype441 @johnniwinther