Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm-msvc-windows is broken by unwinding_records change #52002

Closed
aam opened this issue Apr 10, 2023 · 0 comments
Closed

vm-msvc-windows is broken by unwinding_records change #52002

aam opened this issue Apr 10, 2023 · 0 comments
Assignees

Comments

@aam
Copy link
Contributor

aam commented Apr 10, 2023

https://dart.googlesource.com/sdk/+/386a87a8905c48342e1bb9dcbe0ff693690468a7 broke vm-msvc-windows
https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-msvc-windows/4/overview

[1302/2702] CXX obj/runtime/vm/libdart_vm_jit.unwinding_records_win.obj
FAILED: obj/runtime/vm/libdart_vm_jit.unwinding_records_win.obj 
C:/b/s/w/ir/cache/builder/sdk/buildtools/ninja/ninja -t msvc -e environment.x64 -- "C:\b\s\w\ir\kitchen-checkout\depot_tools\win_toolchain\vs_files\1023ce2e82\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64/cl.exe"  /nologo /showIncludes /FC @obj/runtime/vm/libdart_vm_jit.unwinding_records_win.obj.rsp /c ../../runtime/vm/unwinding_records_win.cc /Foobj/runtime/vm/libdart_vm_jit.unwinding_records_win.obj /Fdobj/runtime/vm/libdart_vm_jit_cc.pdb
C:\b\s\w\ir\cache\builder\sdk\runtime\vm\unwinding_records_win.cc(105): error C2440: 'reinterpret_cast': cannot convert from 'dart::uword' to 'DWORD64'
C:\b\s\w\ir\cache\builder\sdk\runtime\vm\unwinding_records_win.cc(105): note: Conversion is a valid standard conversion, which can be performed implicitly or by use of static_cast, C-style cast or function-style cast
C:\b\s\w\ir\cache\builder\sdk\runtime\vm\unwinding_records_win.cc(106): error C2440: 'reinterpret_cast': cannot convert from 'dart::uword' to 'DWORD64'
C:\b\s\w\ir\cache\builder\sdk\runtime\vm\unwinding_records_win.cc(106): note: Conversion is a valid standard conversion, which can be performed implicitly or by use of static_cast, C-style cast or function-style cast
C:\b\s\w\ir\cache\builder\sdk\runtime\vm\unwinding_records_win.cc(100): error C2660: 'RtlAddGrowableFunctionTable': function does not take 4 arguments
C:\b\s\w\ir\kitchen-checkout\depot_tools\win_toolchain\vs_files\1023ce2e82\Windows Kits\10\Include\10.0.20348.0\um\winnt.h(20719): note: see declaration of 'RtlAddGrowableFunctionTable'
@aam aam added the gardening label Apr 10, 2023
@aam aam self-assigned this Apr 10, 2023
copybara-service bot pushed a commit that referenced this issue Apr 10, 2023
TEST=msvc ci
BUG=#52002

Change-Id: I9a2865e6e55c1924e40aa0c946bfe1c3ce969d69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294363
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
@aam aam closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant