[CP] [IO] Use try/catch in lookupAddresses instead of Future error

[a-siva]

Commit(s) to merge

f7ef526

Target

stable 3.1

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/324569

Issue Description

With the Dart 3.1 release a number of Flutter users are facing issues with running their app in the debugger (produces an unhandled exception). For details please see discussion in #53334

What is the fix

This change fixes lookupAddress to use a try/catch instead of returning a Future error, this exception is the one that users where hitting often and with this fix they won't run into it.
The actual fix for the issue has landed in main but is a large change and does not make sense to cherry pick into stable at this point.

Why cherry-pick

A number of Flutter users have run into this issue.

Risk

low

Issue link(s)

#53334

Extra Info

No response

[a-siva]

//cc @mraleph for lgtm

[itsjustkevin]

Approval by @aam on the CL.

[DanTup]

Out of interest, do new Dart stables automatically get rolled into Flutter stable, or do additional issues need creating to cherry-pick them? I looked on https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process but it doesn't seem to describe how Dart cherry-picks get to Flutter.

[athomas]

The releases are generally* aligned and Flutter picks up all Dart releases (except for the Dart dev channel). Technically, Dart releases are cherry-picked into Flutter releases but it's part of the process and doesn't need additional requests.

*We can do a Dart-only release but we'd only do it if Flutter is definitely unaffected by the changes. Probably, happens only every few years (I only remember one example).

[DanTup]

Got it, thanks for the explanation :-)

[fisforfaheem]

thanks

[escamoteur]

I upgraded to 3.13.4 and still have the breaking of the debugger when 'break on uncaught exceptions' is enabled

[a-siva]

I upgraded to 3.13.4 and still have the breaking of the debugger when 'break on uncaught exceptions' is enabled

Can you share the backtrace of the exception that is showing up, it is possible that you are hitting a different exception than the most common one that folks were hitting with lookupAddress. This cherry pick only addresses that case.

[mihalycsaba]

did this fix the exception issue with the http package? dart-lang/http#1008

[a-siva]

did this fix the exception issue with the http package? dart-lang/http#1008

Yes

[escamoteur]

if I enabale `break on all execptions´I still get this here

which I honestly don't understand as the host name is valid, so why would it throw an exception at all

after a flutter clean I now at least can use the setting break on uncaught execptions

[menghui-hata]

I am still getting this error with dio package after upgrading to 3.13.4

[a-siva]

@menghui-hata and @escamoteur the cherry pick done was a work around for the specific exception issue with the staggeredLookup method in dart:io library that a number of folks were hitting, the real fix for the problem is in the main branch (the changes were too many to cherry pick back to the stable channel).