Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Adjust nullability computations in the upper bound algorithm in the CFE #53999

Closed
chloestefantsova opened this issue Nov 9, 2023 · 4 comments
Closed

[CP] Adjust nullability computations in the upper bound algorithm in the CFE #53999

chloestefantsova opened this issue Nov 9, 2023 · 4 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-approved Label for approved cherrypick request merge-to-stable

Comments

@chloestefantsova
Copy link
Contributor

Commit(s) to merge

ad298bf

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/333825

Issue Description

Currently the CFE emits some types with incorrect nullability in some cases. According to user reports, it prevents using package typings. The issue is reported for the DDC, but other platforms may be affected as well, because the fix is in the core of the CFE code used by all backends.

What is the fix

The fix adjusts the computations of the nullability in the algorithm for the upper bound between two types in the CFE. The fix is small and self-contained.

Why cherry-pick

The user who reported an issue asked for a fix to land sooner. It seems that they are blocked in their work by being unable to use package typings and don't have a work-around.

Risk

low

Issue link(s)

#52726

Extra Info

My evaluation of the risk as low is based on the assumption that the fix corrects some malformed programs emitted by the CFE, but leaves the well-formed programs intact.
@chloestefantsova chloestefantsova added the cherry-pick-review Issue that need cherry pick triage to approve label Nov 9, 2023
@mit-mit
Copy link
Member

mit-mit commented Nov 10, 2023

LGTM

@a-siva a-siva added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label Nov 13, 2023
@itsjustkevin
Copy link
Contributor

@chloestefantsova is this still needed in stable 3.2?

@chloestefantsova
Copy link
Contributor Author

@itsjustkevin This is not a blocker for 3.2, but I'd like to have it included it into the next release.

@itsjustkevin itsjustkevin added cherry-pick-approved Label for approved cherrypick request merge-to-stable labels Nov 17, 2023
copybara-service bot pushed a commit that referenced this issue Nov 24, 2023
@chloestefantsova
[stable][cfe] Adjust the nullability of UP w.r.t. undetermined RHS
b6227bf 
Closes #52726

Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/334441
Cherry-pick-request: #53999
Fixes: #53999
Change-Id: I365c548c3a3a203797cbd73ec7798ff29dfd3f98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333825
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
@athomas athomas removed the cherry-pick-review Issue that need cherry pick triage to approve label Nov 27, 2023
@athomas
Copy link
Member

athomas commented Dec 5, 2023

Released in 3.2.2.

@athomas athomas closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-approved Label for approved cherrypick request merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@chloestefantsova @vsmenon @whesse @a-siva @itsjustkevin @mit-mit @athomas