Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] DDS and DevTools server change: fix an issue with serving static DevTools assets. #54428

Closed
kenzieschmoll opened this issue Dec 20, 2023 · 1 comment
Closed

[CP] DDS and DevTools server change: fix an issue with serving static DevTools assets. #54428

kenzieschmoll opened this issue Dec 20, 2023 · 1 comment
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve pkg-dds For issues related to the Dart Development Service

Comments

@kenzieschmoll
Copy link
Contributor

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/343000

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/343002

Issue Description

There was an issue when serving static assets from DevTools. If we could not find the file, the devtools server would just crash instead of handling the failure gracefully.

What is the fix

The fix was to add try catch blocks around the problematic code and return a Response.notfound in the event that we could not find the file.

Why cherry-pick

This is preventing DevTools extensions from loading properly.

Risk

low

Issue link(s)

n/a

Extra Info

No response
@kenzieschmoll kenzieschmoll added the cherry-pick-review Issue that need cherry pick triage to approve label Dec 20, 2023
@mit-mit
Copy link
Member

mit-mit commented Dec 21, 2023

SGTM

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label Dec 21, 2023
copybara-service bot pushed a commit that referenced this issue Dec 21, 2023
@kenzieschmoll @itsjustkevin
[stable] Cherry-pick DDS and DevTools server change: fix an issue wit…
904f724 
…h serving static DevTools assets.

Bug: #54428
Change-Id: Ib07d5812afd79b204373d31bb431401c207413aa
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/343000
Cherry-pick-request: #54428
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/343002
Reviewed-by: Derek Xu <derekx@google.com>
@lrhn lrhn added area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. pkg-dds For issues related to the Dart Development Service labels Dec 25, 2023
@lrhn lrhn closed this as completed Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve pkg-dds For issues related to the Dart Development Service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@vsmenon @lrhn @whesse @itsjustkevin @mit-mit @athomas @kenzieschmoll