Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAP should use requirePermissionToResume to make sure that DDS waits for its call to resume #54843

Open
elliette opened this issue Feb 7, 2024 · 0 comments
Open

DAP should use requirePermissionToResume to make sure that DDS waits for its call to resume #54843

elliette opened this issue Feb 7, 2024 · 0 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation

Comments

@elliette
Copy link
Contributor

elliette commented Feb 7, 2024 •
edited
Loading

Use DDS' requirePermissionsToResume API to make sure that when pause-isolates-on-start is set, DDS waits for resume request from all clients, including DAP.

Context here: dart-lang/webdev#2257 (comment)
@elliette elliette added the dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation label Feb 7, 2024
@devoncarew devoncarew added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Feb 7, 2024
@elliette elliette changed the title DAP should use requirePermissionToResume to pause any isolates on restart until breakpoints can be set DAP should use requirePermissionToResume to make sure that DDS waits for its call to resume Feb 14, 2024
copybara-service bot pushed a commit that referenced this issue May 6, 2024
@elliette
[DAP] Set requirePermissionToResume and `requireUserPermissionToRes…
Loading
Loading status checks…
93556ae 
…ume` for `onPauseStart` and `onPauseExit` so that DDS waits for DAP's permission before resuming the isolate.

Bug: #54843
Change-Id: I12686d6c683983b7af5a3148681410ff9c684343
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350649
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Elliott Brooks <elliottbrooks@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devoncarew @elliette