[CP] [dart2wasm] Fix array.new_fixed calls with too large size #55873
Assignees
Labels
cherry-pick-approved
Label for approved cherrypick request
cherry-pick-review
Issue that need cherry pick triage to approve
Comments
mkustermann
added
the
cherry-pick-review
This was referenced May 30, 2024
|
@mraleph could you take a look at this cherry-pick request? |
|
LGTM |
|
@itsjustkevin if you approve, I'll merge the CL |
|
Approved! Merge away @mkustermann! |
itsjustkevin
added
the
cherry-pick-approved
copybara-service bot
pushed a commit
that referenced
this issue
May 30, 2024
Currently `array.new_fixed` has the upper size limit of 10,000. Larger arrays need to be initialized with `array.new` or `array.new_default`. We handle this correctly in constant list and strings, but we didn't handle it in `WasmArray.literal` consturctor. This CL fixes it. Bug: #55396 Bug: #55872 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/361780 Cherry-pick-request: #55873 Change-Id: I97c8dc104cb4231ba0508d9cd87690cf1bbe95a9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368644 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Ömer Ağacan <omersa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
c7834b6
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/368644
Issue Description
Certain large apps can result in dart2wasm emitting an
array.new_fixedinstruction with more than 10000 elements, which causes a runtime error when running in browsers.What is the fix
Avoid using
array.new_fixedif the array is larger than 10000Why cherry-pick
Users are hitting this on stable channel.
Risk
Low
Issue link(s)
#55396, #55872
Extra Info
No response
The text was updated successfully, but these errors were encountered: