Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] [dart2wasm] Make dart compile wasm accept --enable-experiment flags and pass those to compiler #55894

Closed
mkustermann opened this issue Jun 1, 2024 · 4 comments
Closed

[CP] [dart2wasm] Make dart compile wasm accept --enable-experiment flags and pass those to compiler #55894

mkustermann opened this issue Jun 1, 2024 · 4 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@mkustermann
Copy link
Member

Commit(s) to merge

3b02e41

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/369240

Issue Description

We want dart compile wasm to support --enable-experiment so that e.g. the test runner can use it (dart-lang/test#2233)

What is the fix

Add dart compile wasm support for --enable-experiment.

Why cherry-pick

So that e.g. the test runner can use it (dart-lang/test#2233)

Risk

Low

Issue link(s)

Extra Info

No response
@mkustermann mkustermann added the cherry-pick-review Issue that need cherry pick triage to approve label Jun 1, 2024
@mkustermann
Copy link
Member Author

/cc @kevmoo

@mkustermann mkustermann mentioned this issue Jun 1, 2024
Merged
@kevmoo
Copy link
Member

kevmoo commented Jun 1, 2024

LGTM!

@mit-mit
Copy link
Member

mit-mit commented Jun 3, 2024

SGTM

@athomas athomas added the cherry-pick-approved Label for approved cherrypick request label Jun 3, 2024
copybara-service bot pushed a commit that referenced this issue Jun 3, 2024
@mkustermann
[stable] [dart2wasm] Make dart compile wasm accept --enable-experim…
7b7786a 
…ent flags and pass those to compiler

This is a preparation for making CI bot to run using `dart compile wasm`
instead of `pkg/dart2wasm/tool/compile_benchmark`.

Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/366820
Cherry-pick-request: #55894
Change-Id: I1e3804019363418ac7d00ec77042ffe2b6f62154
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369240
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
@mkustermann
Copy link
Member Author

The CP was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @vsmenon @mkustermann @itsjustkevin @mit-mit @athomas