Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unintended_html_in_doc_comment triggers on some variants of allowed html tags in package:web #56450

Open
srujzs opened this issue Aug 12, 2024 · 1 comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@srujzs
Copy link
Contributor

srujzs commented Aug 12, 2024

package:web uses the MDN docs to populate Dart docs for various members. These docs contain some variants of allowed tags like:

<table class="properties">
<th scope="row">
<br />

that trigger this lint. These seem to be the only tags that trigger the lint, but I haven't checked all of the violations as there are quite a few. IIUC, these use cases should not trigger the lint.

@srujzs srujzs added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-linter Issues with the analyzer's support for the linter package labels Aug 12, 2024
copybara-service bot pushed a commit that referenced this issue Aug 13, 2024
Follow up to https://dart-review.googlesource.com/c/sdk/+/379519
Adding a few more tests and making sure the regex isn't instantiated every time
we check.
Added some tests from #56450 as well.

Change-Id: Ief895cdfb5fa1049ce4599e2241577e91bc5701a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
@kallentu
Copy link
Member

The fix for this issue should be in this commit btw! df283fd

@keertip keertip added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P2 A bug or feature request we're likely to work on labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants