Flag if (A) { B } else if (A) { C }

[filiph]

  if (aSource.mType == NS_STYLE_CLIP_PATH_URL) {
    SetURL(aSource.mURL);
  } else if (aSource.mType == NS_STYLE_CLIP_PATH_SHAPE) {
    SetBasicShape(aSource.mBasicShape, aSource.mSizingBox);
  } else if (aSource.mType == NS_STYLE_CLIP_PATH_SHAPE) {
    SetSizingBox(aSource.mSizingBox);
  }

Seems to be another common copy-paste error.

[dikmax]

I think this one is implemented in invariant_boolean rule (#229) and can be closed.

[bwilkerson]

@alexeieleusis Can you confirm that this case is covered?

[alexeieleusis]

It is linted with the specified rule, tested with the following snippet:

void nestedOk4_1() {
  if (foo <= bar) {
    return;
  } else if (foo <= bar) { // LINT
    print('hola mundo!');
  } else if (foo <= bar) { // LINT
    print('hello world!');
  }
}

Should we add it as a test case?

[bwilkerson]

If there isn't already a test to test this case, that would be a good idea, but there's no point in testing it twice.