Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: no compile error when a getter declaration includes parentheses #5890

Closed
DartBot opened this issue Oct 15, 2012 · 6 comments
Closed

VM: no compile error when a getter declaration includes parentheses #5890

DartBot opened this issue Oct 15, 2012 · 6 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Milestone

Comments

@DartBot
Copy link

DartBot commented Oct 15, 2012

This issue was originally filed by rodion...@unipro.ru


Spec says:
classMemberDe nition:
  declaration `;' |
  methodSignature functionBody
;

methodSignature:
  ...
  static? getterSignature |
  ...
;

getterSignature:
  returnType? get identifier
;

but there's no compile-time error when running co19 test Language/07_Classes/2_Getters_A01_t03:

class C {
  get getter() { throw new C(); }
}

main() {
  try {
    var x = new C().getter;
  } on C catch(ok) {}
}

@dgrove
Copy link
Contributor

dgrove commented Oct 16, 2012

Added Area-VM, Triaged labels.

@iposva-google
Copy link
Contributor

What remains to be done is the compatibility with legacy code should be removed now.


Set owner to @mhausner.
Added this to the M2 milestone.
Added Accepted label.

@DartBot
Copy link
Author

DartBot commented Oct 16, 2012

This comment was originally written by @mhausner


I am running co19 at r373, with support for the old getter syntax removed. I get errors in 40+ tests. Re-opened co19 issue #202.


Added Started label.

@kasperl
Copy link

kasperl commented Dec 11, 2012

Has this been fixed?

@DartBot
Copy link
Author

DartBot commented Dec 11, 2012

This comment was originally written by rodion...@unipro.ru


just ran the tests, the expected compile error is there

@DartBot
Copy link
Author

DartBot commented Dec 11, 2012

This comment was originally written by @mhausner


Yes, this was checked in at r15532.


Added Fixed label.

@DartBot DartBot added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Dec 11, 2012
@DartBot DartBot added this to the M2 milestone Dec 11, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

4 participants