Bogus unnecessary_this with pattern matching and shadowing

[nex3]

For the code below:

class Foo {
  Object? value;

  bool equals(Object other) => switch (other) {
    Foo(: var value) => this.value == value,
    _ => false
  };
}

the 3.0.0 analyzer will print

info - test.dart:5:25 - Unnecessary 'this.' qualifier. Try removing 'this.'. - unnecessary_this

This is incorrect. The this. is necessary to disambiguate the containing class's value field from the value variable bound by the switch expression.

[pq]

Good catch. Taking a look now. Thanks!

[pq]

It looks like the issue is percolating up from analyzer.

Tracking in #52486