build.py -m debug (or -m debug,release) fails

[dgrove]

As of r2028, a top-level debug build is failing because frog is looking for release binaries.

[dgrove]

Issue #668 has been merged into this issue.

[dgrove]

Added Triaged label.

[sigmundch]

+ngeoffray - maybe you have some additional suggestions

I can think of two possible solutions:

• build frogsh using the debug vm (it works, but takes 30 sec instead of 3 on my box)
• make the build not fail, but create a frogsh that, when runs, it asks you to rerun the build.py first with release, then with debug again.

[sigmundch]

I submitted a fix that takes the second approach for now.

---

Added Fixed label.

[iposva-google]

The second approach does not address this critical problem I raised in the original issue #668:

As you rebuild debug it will keep using an out-of-date Dart VM binary. This build needs to honor the current(!) build mode.

---

Added Triaged label.

[DartBot]

This comment was originally written by ngeoffray@google.com

---

Thank you Siggi for the fix. To address Ivan's concerns, I suggest either:

1. Use the debug build of the VM to build frog. But last time I did that, build time got pretty big.

2. Build a release version of the VM in the debug build. So when doing build.py -m debug, you end up building out/Debug/dart (debug version), and out/Debug/dart_release (release version).

---

cc @peter-ahe-google.

[DartBot]

This comment was originally written by ngeoffray@google.com

---

The issue is now fixed. We use the debug VM to build debug frog.

---

Added Fixed label.

[iposva-google]

Build works now, but test does not. This is the test output from r2393 after a clean debug build:

staine[dart] time ./tools/test.py --component=dartc

3671.316u 462.464s 6:01.43 1143.7% 0+0k 0+772io 0pf+0w
staine[dart] time ./tools/test.py --component=frog
=== debugia32 frog corelib/CollectionFromTest ===
Path: corelib/CollectionFromTest
Dart VM not built. Please run the following command:
 tools/build.py -m release
Command: xcodebuild/Debug_ia32/frog/bin/frog --ignore-unrecognized-flags /Sources/dart-all/dart/tests/corelib/src/CollectionFromTest.dart

---

Added Triaged label.

[DartBot]

This comment was originally written by ngeoffray@google.com

---

Thanks Ivan for verifying. http://codereview.chromium.org/8931023/ should have fixed the problem now.

Running test.py with frog in debug mode now takes an hour. The buildbots do not build frog in debug mode, so they're not affected.

---

Added Fixed label.