Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems correctly resolving name when same name used in co-importing libraries #686

Closed
rakudrama opened this issue Dec 5, 2011 · 3 comments
Closed

Problems correctly resolving name when same name used in co-importing libraries #686

rakudrama opened this issue Dec 5, 2011 · 3 comments
Assignees
@crelier
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@rakudrama
Copy link
Member

Dart VM gives the following error for the example at
http://codereview.chromium.org/8806001

'/usr/local/google/home/sra/dart-all/dart/tests/language/src/LibrarySameNameUsedLib2.dart': Error: Class 'X' is used where an interface is expected

There are two problems:
(1) I believe the code is legal - the class X is a new type, and should not be confused with lib1.X

(2) The error does not identify any source locations, so it is not actionable. I can't tell if the problem is 'class X' or 'implements lib1.X'
@rakudrama
Copy link
Member Author

Test case:
http://codereview.chromium.org/8806019

@crelier
Copy link
Contributor

crelier commented Jan 30, 2012

Set owner to @crelier.
Added Started label.

@crelier
Copy link
Contributor

crelier commented Jan 31, 2012

Fixed in r3703.

Added Fixed label.

@rakudrama rakudrama added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Jan 31, 2012
copybara-service bot pushed a commit that referenced this issue Aug 23, 2023
@devoncarew
[deps] rev ecosystem, mockito, tools, webdriver
0e2e859 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/dfeda1a..f777da7):
  f777da7  2023-08-22  Devon Carew  updates to the label normalization tool (#151)
  73a3464  2023-08-04  Moritz  Add permissions to `post_summaries.yaml` (#149)

mockito (https://github.com/dart-lang/mockito/compare/e54a006..70aabfc):
  70aabfc  2023-08-23  Copybara-Service  Merge pull request #686 from parlough:fix/example-analysis-errors
  9737d71  2023-08-15  Parker Lougheed  Fix analysis errors in example directory

tools (https://github.com/dart-lang/tools/compare/2be6c2e..e5ce42a):
  e5ce42a  2023-08-22  Jonas Finnemann Jensen  Support optional packageUri (#148)
  1c46390  2023-08-21  Kenzie Davisson  Improve exception messages for `ExpectJson` extension (#147)

webdriver (https://github.com/google/webdriver.dart/compare/d0f78d0..20ec47f):
  20ec47f  2023-08-21  sigmundch  Add content-type to async xhr request headers. (#277)

Change-Id: If6483e07c9d2a3670d2a9043bd56f40965e25c3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322362
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crelier crelier

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rakudrama @crelier