Skip to content

declaredIndentifier typos in Dart Language Specification, Draft Version 0.01, October 10th, 2011 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DartBot opened this issue Oct 10, 2011 · 5 comments
Closed

declaredIndentifier typos in Dart Language Specification, Draft Version 0.01, October 10th, 2011 #7

DartBot opened this issue Oct 10, 2011 · 5 comments
Assignees
@gbracha

Comments

@DartBot
Copy link

DartBot commented Oct 10, 2011

This issue was originally filed by adrian.ai...@gmail.com

What steps will reproduce the problem?

  1. Open http://www.dartlang.org/docs/spec/dartLangSpec.pdf
  2. Search for "indent" (without the quotes)
  3. Notice how this should rather read ident instead.

What is the expected output? What do you see instead?

I see what must be a typo.

What version of the product are you using? On what operating system?

Dart Programming Language Specification
Draft Version 0.01
The Dart Team
October 10th, 2011

Please provide any additional information below.

Here is a copy/paste from the pdf (with the fi ligature manually reapaired). See my (sic) annotations for where I think the typos are:

11.9

Try

The try statement supports the definition of exception handling code in a struc-
tured way.

tryStatement:
try block (catchPart+ finallyPart? | finallyPart)
;

catchPart:
catch ‘(’ declaredIndentifier (sic) (‘, ’ declaredIndentifier (sic))? ‘)’ block
;

finallyPart:
finally block
;
@iposva-google
Copy link
Contributor

Set owner to @gbracha.

@DartBot
Copy link
Author

DartBot commented Oct 11, 2011

This comment was originally written by drfibonacci@google.com

Removed the owner.
Added Component-Docs, Accepted labels.

@DartBot
Copy link
Author

DartBot commented Oct 11, 2011

This comment was originally written by drfibonacci@google.com

Set owner to @kwalrath.

@kwalrath
Copy link
Contributor

Back to Gilad, who can reassign to me once he has a new PDF ready.

Set owner to @gbracha.

@gbracha
Copy link
Contributor

gbracha commented Oct 12, 2011

Added Done label.

@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@gbracha gbracha mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
@nex3 nex3 mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Open
@kasperl kasperl mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
@crelier crelier mentioned this issue Jun 3, 2015
Closed
@andersjohnsen andersjohnsen mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@nex3 nex3 mentioned this issue Jun 3, 2015
Closed
@whesse whesse mentioned this issue Jun 3, 2015
Closed
@sigmundch sigmundch mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
@nex3 nex3 mentioned this issue Jun 3, 2015
Closed
@majornuts majornuts mentioned this issue Jul 4, 2024
Closed
@Lootwig Lootwig mentioned this issue Jul 18, 2024
Open
@the-mrinal the-mrinal mentioned this issue Jul 31, 2024
Open
@aam aam mentioned this issue Jul 31, 2024
Closed
@ailabs-software ailabs-software mentioned this issue Aug 6, 2024
Closed
@thermoworker thermoworker mentioned this issue Aug 12, 2024
Closed
@theaquaflower theaquaflower mentioned this issue Aug 15, 2024
Closed
@724898928 724898928 mentioned this issue Sep 4, 2024
Open
@SwederSchellens SwederSchellens mentioned this issue Sep 24, 2024
Closed
@mjablecnik mjablecnik mentioned this issue Sep 27, 2024
Open
@ChaserVasya ChaserVasya mentioned this issue Oct 20, 2024
Open
copybara-service bot pushed a commit that referenced this issue Oct 22, 2024
@pq
[element model] fix unsafe ConstructorMember cast
f65f719 
See: b/374689139.

https://dart-review.googlesource.com/c/sdk/+/390941 is blocking an SDK roll.

Root cause:


```
Action threw an exception: type 'ConstructorMember' is not a subtype of type 'ConstructorFragment' in type cast
#0      InterfaceTypeImpl.constructors2.<anonymous closure> (package:analyzer/src/dart/element/type.dart:569)
#1      MappedListIterable.elementAt (dart:_internal/iterable.dart:435)
#2      ListIterator.moveNext (dart:_internal/iterable.dart:364)
#3      new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189)
#4      new _GrowableList.of (dart:core-patch/growable_array.dart:150)
#5      new List.of (dart:core-patch/array_patch.dart:39)
#6      ListIterable.toList (dart:_internal/iterable.dart:224)
#7      InterfaceTypeImpl.constructors2 (package:analyzer/src/dart/element/type.dart:570)
#8      _Visitor._hasConstConstructorInvocation (package:linter/src/rules/prefer_const_constructors_in_immutables.dart:110)
#9      _Visitor.visitConstructorDeclaration (package:linter/src/rules/prefer_const_constructors_in_immutables.dart:58)
```


To verify the fix locally:

```
  solo_test_X() async {
    await assertNoErrorsInCode(r'''
class A<T> {}
''');

    var A = findElement.class_('A').instantiate(
      typeArguments: [intType],
      nullabilitySuffix: NullabilitySuffix.none,
    );
    A.constructors2;
  }
```


Bug: b/374689139
Change-Id: I70034d938d840dc0c3939db27e7116164e4617e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391483
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Open
@MLDenzzl MLDenzzl mentioned this issue Oct 28, 2024
Closed
@pq pq mentioned this issue Nov 18, 2024
Closed
@neoapps-dev neoapps-dev mentioned this issue Nov 28, 2024
Closed
@thermoworker thermoworker mentioned this issue Dec 18, 2024
Open
@hasimyerlikaya hasimyerlikaya mentioned this issue Dec 19, 2024
Open
@ac-arconomy ac-arconomy mentioned this issue Jan 9, 2025
Closed
@Kaushik-Mandale Kaushik-Mandale mentioned this issue Feb 5, 2025
Closed
@NiclasLeichsenring NiclasLeichsenring mentioned this issue Feb 19, 2025
Closed
copybara-service bot pushed a commit that referenced this issue Feb 21, 2025
@alexmarkov
[tests] Fix flaky standalone/io/http_auth_digest_test
b2c8b31 
This test has a few independent calls to asyncExpectThrows which uses
asyncStart/asyncEnd. However, multiple top-level asyncStart/asyncEnd
are not allowed, which causes the following flaky error:

```
Unhandled exception:
Exception: Fatal: asyncStart() was called even though we are done with testing.. This is most likely a bug in your test.
#0      asyncStart (package:expect/async_helper.dart:53)
#1      asyncExpectThrows (package:expect/async_helper.dart:140)
#2      testMalformedAuthenticateHeaderWithAuthHandler.<anonymous closure> (file:///b/s/w/ir/cache/builder/sdk/tests/standalone/io/http_auth_digest_test.dart:345)
#3      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:951)
#4      Future._propagateToListeners (dart:async/future_impl.dart:980)
#5      Future._completeWithValue (dart:async/future_impl.dart:723)
#6      Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:807)
#7      _microtaskLoop (dart:async/schedule_microtask.dart:40)
#8      _startMicrotaskLoop (dart:async/schedule_microtask.dart:49)
#9      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:128)
#10     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:195)

--- Re-run this test:
python3 tools/test.py -n vm-aot-ubsan-linux-release-x64 standalone/io/http_auth_digest_test
```

This change attempts to fix this by adding a top-level asyncStart/asyncEnd
and also asyncStart/asyncEnd to the server start/shutdown to
enclose each test case into asyncStart/asyncEnd and avoid printing
"unittest-suite-success" marker before all test cases are finished.

TEST=standalone/io/http_auth_digest_test

Change-Id: I950e7c6c09f5c2144da874ab3be3cd3a130d3790
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411086
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
This was referenced Mar 20, 2025
Closed
Closed
@brighttank brighttank mentioned this issue Mar 24, 2025
Closed
@kjamespoulson kjamespoulson mentioned this issue Mar 28, 2025
Closed
copybara-service bot pushed a commit that referenced this issue Apr 18, 2025
Roll BoringSSL from ef839bf397fb to 45a865d6682a (15 revisions)
969eeaa 
https://boringssl.googlesource.com/boringssl.git/+log/ef839bf397fb..45a865d6682a

2025-04-14 davidben@google.com Update tools, etc
2025-04-14 davidben@google.com Switch to the CIPD Windows SDK package
2025-04-14 davidben@google.com Implement functions to generate CMS external signatures
2025-04-14 davidben@google.com Move most PKCS #7 test data to files
2025-04-14 davidben@google.com Add CBB_flush_asn1_set_of calls to pkcs7_add_signed_data
2025-04-14 davidben@google.com Add EVP_marshal_digest_algorithm_no_params
2025-04-14 davidben@google.com Add some CBB-based functions for crypto/x509 and crypto/asn1 types
2025-04-14 davidben@google.com Shave 8 bytes off EVP_AEAD_CTX
2025-04-10 bbe@google.com Fix backward check in crl_crldp_check
2025-04-10 davidben@google.com Remove OPENSSL_CAN_USE_ATTR_FALLTHROUGH
2025-04-10 davidben@google.com Remove EVP_MD_FLAG_PKEY_DIGEST
2025-04-09 agl@chromium.org Remove MAC truncation from FIPS interface.
2025-04-08 davidben@google.com Remove B_ASN1_UNKNOWN
2025-04-08 davidben@google.com Support ANY attribute values in X509_NAME
2025-04-08 davidben@google.com Remove ASN1_PRINTABLE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-vm-gardener@grotations.appspotmail.com
Change-Id: I6bab0593a9d2fbf75b014e6ded05c5f303287613
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422420
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
copybara-service bot pushed a commit that referenced this issue May 1, 2025
@alexmarkov
[tests] Fix flaky standalone/io/http_auth_test
0fe2a31 
This is an attempt to fix flaky failure

```
Unhandled exception:
Exception: Fatal: asyncStart() was called even though we are done with testing.. This is most likely a bug in your test.
#0      asyncStart (package:expect/async_helper.dart:53)
#1      asyncExpectThrows (package:expect/async_helper.dart:140)
#2      testMalformedAuthenticateHeaderWithAuthHandler.<anonymous closure> (file:///C:/b/s/w/ir/tests/standalone/io/http_auth_test.dart:263)
#3      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:951)
#4      Future._propagateToListeners (dart:async/future_impl.dart:980)
#5      Future._completeWithValue (dart:async/future_impl.dart:723)
#6      Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:807)
#7      _microtaskLoop (dart:async/schedule_microtask.dart:42)
#8      _startMicrotaskLoop (dart:async/schedule_microtask.dart:60)
#9      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:127)
#10     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:194)

--- Re-run this test:
python3 tools/test.py -n vm-aot-win-release-x64 standalone/io/http_auth_test
```

The test has multiple calls to asyncExpectThrows which uses
asyncStart/asyncEnd, but only one top-level asyncStart/asyncEnd is
allowed.

In addition to a top-level asyncStart/asyncEnd, also add
asyncStart/asyncEnd around creation and shutdown of the server in order
to make sure all test cases are completed before test is finished.

TEST=standalone/io/http_auth_test

Change-Id: Ibb55dbae2c2e48e18f51f9a0adc24101d6121a8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425600
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
@Sakari369 Sakari369 mentioned this issue May 7, 2025
Closed
@Luxorum Luxorum mentioned this issue May 12, 2025
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbracha gbracha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kwalrath @gbracha @iposva-google @DartBot