Skip to content

Need gypi files for client/dom #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dgrove opened this issue Dec 8, 2011 · 5 comments
Closed

Need gypi files for client/dom #754

dgrove opened this issue Dec 8, 2011 · 5 comments
Assignees
@vsmenon

Comments

@dgrove
Copy link
Contributor

dgrove commented Dec 8, 2011

The SDK build doesn't have a way of knowing that the DOM has changed - we need a gypi file and target.
@vsmenon
Copy link
Member

vsmenon commented Dec 8, 2011

The gyp is auto-generated and placed here:

compiler/domlib_sources.gypi

@dgrove
Copy link
Contributor Author

dgrove commented Dec 8, 2011

Can we get move this to the dom directory?

@vsmenon
Copy link
Member

vsmenon commented Dec 8, 2011

Can you clarify if this is for frog or for dartc? They have/depend on different sources.

@dgrove
Copy link
Contributor Author

dgrove commented Dec 8, 2011

I want to know both of these. The SDK build needs to know when things it's
going to package change.

@vsmenon
Copy link
Member

vsmenon commented Dec 12, 2011

Fixed in 2322.

Added Fixed label.

copybara-service bot pushed a commit that referenced this issue Sep 22, 2022
@osa1
259546: Roll Dart Protobuf Support from cd0ff30759d8 to 1d175bef6043
2c612c1 
Re-submitting 259546 with updated golden tests.

https://dart.googlesource.com/protobuf/+log/cd0ff30759d8..1d175bef6043

2022-09-16 omersa@google.com Fix $_getMap return value when mutability when message is read-only (#754)
2022-09-16 omersa@google.com Eliminate more type casts when targeting JS (#732)
2022-09-15 omersa@google.com Make subBuilder args of BuilderInfo message methods required (#753)

Change-Id: I0447b0ba277251e49dc373941599039e0e041019
Tested: CL updates test golden expectations
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259740
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgrove @vsmenon