Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyboardEvent has no method preventDefault #903

Closed
DartBot opened this issue Dec 18, 2011 · 3 comments
Closed

KeyboardEvent has no method preventDefault #903

DartBot opened this issue Dec 18, 2011 · 3 comments
Assignees
@nex3
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable

Comments

@DartBot
Copy link

DartBot commented Dec 18, 2011

This issue was originally filed by jeffbailey@google.com

What steps will reproduce the problem?

document.on.keyDown.add((KeyboardEvent evt) {
  evt.preventDefault();
}

What is the expected output? What do you see instead?

Gives a runtime error of preventDefault not being defined. I expect it to chain through to the DOM method to call preventDefault.

What version of the product are you using? On what operating system?

Revision: 2481 on Goobuntu
@dgrove
Copy link
Contributor

dgrove commented Dec 18, 2011

Set owner to @jacob314.
Added Area-UI, Triaged labels.

@jacob314
Copy link
Member

Set owner to @nex3.

@nex3
Copy link
Member

nex3 commented Jan 17, 2012

I can't reproduce this. If this is still occurring, feel free to re-open and I'll take a deeper look, but I think it may have been incidentally fixed since reporting.

Added Invalid label.

@DartBot DartBot added Type-Defect closed-invalid Closed as we don't believe the reported issue is generally actionable labels Jan 17, 2012
copybara-service bot pushed a commit that referenced this issue Nov 27, 2023
@devoncarew
[deps] rev ecosystem, matcher, native, protobuf, sse, test, vector_ma…
f913216 
…th, watcher

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/dda7886..805ab4f):
  805ab4f  2023-11-22  Moritz  Add retries to `pub.dev/api/` calls (#199)
  4cc2cb4  2023-11-20  Devon Carew  add PR stats to the 'bin/report.dart weekly' command (#198)

matcher (https://github.com/dart-lang/matcher/compare/3d03fa1..fcbd361):
  fcbd361  2023-11-21  Nate Bosch  Add more advice away from predicate (#233)

native (https://github.com/dart-lang/native/compare/5dca10e..0051e78):
  0051e78d  2023-11-27  Hossein Yousefi  Generate getters for `static final` strings (#825)
  de505461  2023-11-27  Liam Appelbe  [ffigen] Update the ObjC and swift examples for the v10 code gen (#830)
  c371539d  2023-11-24  Simon Binder  ffigen: Don't generate setters for constant globals (#828)
  13b6b7e7  2023-11-24  Luke Rogers  Fixed a typo in the warn if private log message. (#824)
  9f29edc7  2023-11-21  Prerak Mann  [ffigen] Add config `ignore-source-errors`  (#810)
  6dc1c84c  2023-11-21  Hossein Yousefi  [infra] Add an issue template for jnigen (#820)
  3153a354  2023-11-21  Hossein Yousefi  [jnigen] Fix flaky tests (#814)
  8d4a241c  2023-11-21  Daco Harkes  [native_assets_cli] Add note to bump protocol version (#819)
  6c6a3d6c  2023-11-21  Daco Harkes  [infra] script to change deps to path dependencies (#817)
  893433ee  2023-11-20  Daco Harkes  [infra] Set `breaking-change` to false again (#816)
  992a563f  2023-11-20  Daco Harkes  [infra] Try to use `carryforward` (#815)
  7d9fbf38  2023-11-20  Daco Harkes  [infra] Try fix coveralls (#813)
  44861422  2023-11-20  Hossein Yousefi  [jnigen] Update links and paths to use dart-lang/native (#811)

protobuf (https://github.com/dart-lang/protobuf/compare/dcec2ed..cf43230):
  cf43230  2023-11-23  Ömer Sinan Ağacan  Update getList and getMap return types (#903)
  4e0bdff  2023-11-23  Ömer Sinan Ağacan  Make wrapped lists in PbList monomorphic (#902)

sse (https://github.com/dart-lang/sse/compare/0f6ca11..1df63f2):
  1df63f2  2023-11-21  Kevin Moore  Fix incorrect cast causing wasm failure, prepare v4.1.4 (#96)

test (https://github.com/dart-lang/test/compare/8ba0940..a0a4d1e):
  a0a4d1ee  2023-11-22  Kevin Moore  Update to latest version of lints (#2140)

vector_math (https://github.com/google/vector_math.dart/compare/294896d..e4066cc):
  e4066cc  2023-11-27  Lukas Klingsbo  Some general Vector4 optimizations (#295)
  d340ab0  2023-11-27  Lukas Klingsbo  Some general Vector3 optimizations (#294)
  571d3d0  2023-11-25  Lukas Klingsbo  fix: Revert Vector2 constructor changes (#304)

watcher (https://github.com/dart-lang/watcher/compare/b2b278a..6ac67f1):
  6ac67f1  2023-11-22  Danny Tuppeny  Enable file watcher tests on Windows (#156)

Change-Id: I0014566b05e852099bc4b82f854820e9d9992358
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338423
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 4, 2023
@devoncarew
[deps] rev browser_launcher, ecosystem, http_multi_server, markdown, …
ff80836 
…mime, protobuf, pub_semver, sse, string_scanner, term_glyph, test, test_reflective_loader, typed_data, vector_math, web, webdriver

Revisions updated by `dart tools/rev_sdk_deps.dart`.

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/f60df1d..c68ec25):
  c68ec25  2023-12-04  Kevin Moore  drop outdated lints

ecosystem (https://github.com/dart-lang/ecosystem/compare/805ab4f..79a1bc5):
  79a1bc5  2023-12-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#204)
  c51c500  2023-12-01  dependabot[bot]  Bump actions/github-script (#202)
  64eeeee  2023-12-01  dependabot[bot]  Bump peter-evans/create-or-update-comment (#203)
  32461a7  2023-12-01  Moritz  Upgrades to `health.yaml` (#201)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/2238a6b..ae48489):
  ae48489  2023-12-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#61)

markdown (https://github.com/dart-lang/markdown/compare/3774ad0..d2e7903):
  d2e7903  2023-12-01  dependabot[bot]  Bump subosito/flutter-action from 2.11.0 to 2.12.0 (#569)
  42d32cb  2023-11-30  Kevin Moore  Update to latest lints, require Dart ^3.1 (#568)

mime (https://github.com/dart-lang/mime/compare/8ebf946..56359b0):
  56359b0  2023-12-05  Yoshihiro Tanaka  Detect HEIC/HEIF format by checking header bytes (#109)

protobuf (https://github.com/dart-lang/protobuf/compare/dcec2ed..bb19774):
  bb19774  2023-11-29  Ömer Sinan Ağacan  Revert `PbMap._wrappedMap` empty map value (#904)
  cf43230  2023-11-23  Ömer Sinan Ağacan  Update getList and getMap return types (#903)
  4e0bdff  2023-11-23  Ömer Sinan Ağacan  Make wrapped lists in PbList monomorphic (#902)

pub_semver (https://github.com/dart-lang/pub_semver/compare/f9e94ee..4572181):
  4572181  2023-12-04  Kevin Moore  drop outdated lints (#96)

sse (https://github.com/dart-lang/sse/compare/1df63f2..8d2e2f0):
  8d2e2f0  2023-12-01  dependabot[bot]  Bump nanasess/setup-chromedriver (#99)
  c6501b3  2023-12-01  Kevin Moore  Drop unneeded dep on pkg:test (#98)

string_scanner (https://github.com/dart-lang/string_scanner/compare/a7105ef..ebc30a3):
  ebc30a3  2023-12-04  Kevin Moore  Update to latest lints and cleanup (#67)

term_glyph (https://github.com/dart-lang/term_glyph/compare/7c1eb9d..4c5a496):
  4c5a496  2023-12-04  Kevin Moore  drop outdated lints (#46)

test (https://github.com/dart-lang/test/compare/a0a4d1e..9fffb48):
  9fffb489  2023-12-01  dependabot[bot]  Bump github/codeql-action from 2.22.5 to 2.22.8 (#2145)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/17d40bb..6edf535):
  6edf535  2023-11-30  Kevin Moore  Update lints, bump min SDK to ^3.1.0 (#56)

typed_data (https://github.com/dart-lang/typed_data/compare/0b16bd2..6f6d81d):
  6f6d81d  2023-12-04  Kevin Moore  drop outdated lints (#78)

vector_math (https://github.com/google/vector_math.dart/compare/cca3cf1..38a00c3):
  38a00c3  2023-12-04  Kevin Moore  Update to latest lints and cleanup (#309)
  cedd304  2023-12-04  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#307)

web (https://github.com/dart-lang/web/compare/cffc2e3..865aeaf):
  865aeaf  2023-12-01  Devon Carew  update the CI workflow to test the generation script (#112)

webdriver (https://github.com/google/webdriver.dart/compare/43ed1db..2c1b6f8):
  2c1b6f8  2023-12-01  dependabot[bot]  Bump nanasess/setup-chromedriver (#290)
  dc988d7  2023-12-01  Devon Carew  update to the latest package:lints (#291)

Change-Id: I2d898b6d772925146630777ef587d29a05288a3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339720
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nex3 nex3

Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nex3 @jacob314 @dgrove @DartBot