-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DartVM: no compile-time error for wrong interface methods overriding #970
Comments
Marked this as being blocked by #1031. |
Changing this is under debate, but my current expectation is that it will not change. |
FYI: dart2js complains about most of these cases. However, dart2js only validates members of instantiated classes and their supertypes. This means that the example in the first comment will not be rejected (unless a --compile-all option is added to dart2js). Marked this as being blocked by #1031. |
The example in the original report works fine now. Added Fixed label. |
2021-01-24 irina.arkhipets@gmail.com Issue #983: Static warning checks corrected. 2021-01-22 irina.arkhipets@gmail.com Issue #983: triple-shift folders re-named correctly, typo in the library paths updated for 2 tests. 2021-01-21 sgrekhov@unipro.ru Fixes #985. LateInitializationError removed 2021-01-20 sgrekhov@unipro.ru Fixes #982. Add tests for The future value type of an asynchronous non-generator function part of NNBD spec 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD type-normalization tests for weak mode added. 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD type-aliases tests for weak mode added. 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tripple-shift tests for weak mode added. 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added for the override checkings. 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added (Leatest-greatest-closures). 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added (Leatest-greatest-closures). 2021-01-18 sgrekhov@unipro.ru Fixes #981. Add tests for Return statements part of NNBD spec 2021-01-18 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode corrected according to the current Spec changes. 2021-01-14 irina.arkhipets@gmail.com Issue #462: Additional comments regarding the constant evaluation issues added to weak mode tests. 2021-01-14 sgrekhov@unipro.ru Fixes #980. Remove warnings expectations for overriding default values of optional parameters tests 2021-01-13 irina.arkhipets@gmail.com Issue #462: Tests for weak mode added to nnbd/weak/flow-analysis directory. 2021-01-12 sgrekhov@unipro.ru #978. Weak mode test changes 2021-01-12 irina.arkhipets@gmail.com Issue #462: Tests for weak mode added to nnbd/weak directory. 2021-01-11 sgrekhov@unipro.ru Fixes #978. Tests updated according to the "flow analysis boolean variable" feature 2020-12-25 irina.arkhipets@gmail.com Issues #463: Tests for weak mode added. 2020-12-25 irina.arkhipets@gmail.com Issues #462, #463: Moved or added new nnbd tests for weak mode, added new tests for strong mode. 2020-12-24 sgrekhov@unipro.ru #970. Usr correct values for ProcessSignal.sigusr1 and ProcessSignal.sigusr2 on Mac 2020-12-24 irina.arkhipets@gmail.com Issue #462: 1. Added nnbd tests for weak mode: exports_*, expression_typing_*, extension_method_resolution_*, future_flattening_*. 2. Moved and re-factored nnbd extension_method_resolution_*, future_flattening_* tests for weak mode into weak folder. 3. Copyrights updated Issue #463: Two exports* tests for strong mode added. 2020-12-24 sgrekhov@unipro.ru Fixes #496. Change tested date to 1 second instead of 1 day to reduce probability to change timezone on DST 2020-12-23 sgrekhov@unipro.ru Fixes #473. Remove UtilsHtml directory 2020-12-23 irina.arkhipets@gmail.com Fix for Issue #462: 1. Added nnbd tests for weak mode: assignability_*, const_evaluation_*, const_objects_*, const_type_var_elimination_*. 2. Moved and re-factored nnbd exports_* tests for weak mode into weak folder. 2020-12-10 sgrekhov@unipro.ru Fixes #976. Remove obsolete errors expectations 2020-12-10 sgrekhov@unipro.ru Fixes #975. Fix wrong expected compile time error type 2020-12-07 sgrekhov@unipro.ru Flag Requirements=nnbd-weak added to the tests that run legacy code Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try Change-Id: I69acc5c0a28fd2e7a2d38f6c9062e5a5854bdfa6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180823 Reviewed-by: William Hesse <whesse@google.com>
This issue was originally filed by ief...@unipro.ru
What steps will reproduce the problem?
consider the following test:
interface I {
void m1();
}
interface J extends I {
void m1(int i);
}
main() {
J j = null;
try {j.m1(null);} catch (var e) {}
}
What is the expected output? What do you see instead?
Expected: compile-time error
Actual: successful completion
What version of the product are you using? On what operating system?
DartVM r2810
Please provide any additional information below.
co19 tests:
LangSpecTest/08_Interfaces/1/Methods/A03/t01
LangSpecTest/08_Interfaces/1/Methods/A03/t02
LangSpecTest/08_Interfaces/1/Methods/A03/t03
LangSpecTest/08_Interfaces/1/Methods/A03/t04
LangSpecTest/08_Interfaces/1/Methods/A04/t01
LangSpecTest/08_Interfaces/1/Methods/A04/t02
LangSpecTest/08_Interfaces/1/Methods/A04/t03
LangSpecTest/08_Interfaces/1/Methods/A04/t04
LangSpecTest/08_Interfaces/1/Methods/A04/t05
The text was updated successfully, but these errors were encountered: