[CoreLib] Iterable.withIterator

[drxddy]

Introduced a new factory constructor for Iterable class withIterator

Closes #55961

Usage

final numbers = Iterable.withIterator(() => [1, 2, 3].iterator);
print(numbers.toList()); // [1, 2, 3]

final numbers = [1, 2, 3];
final iterator = numbers.iterator;
iterator.moveNext();
var lazyIterable = Iterable.withIterator(() => iterator);

// Test that the first element is already consumed
var elements = lazyIterable.toList();  // [2, 3]
Expect.isNotEmpty(elements);
Expect.equals(2, elements.first);

[copybara-service]

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/404341

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[drxddy]

@lrhn I've renamed it to Iterable.withIterator in this change fa07cf8, let me know if anything needs to be changed

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[drxddy]

Hey, I've resolved all the changes suggested by @lrhn, please let me if anything can be better before we can merge it with main

[lrhn]

LGTM. Small suggestions on the private class, nothing visible.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[drxddy]

Hi @lrhn, I've made these changes the latest commit 458904f

• renamed the private class to _WithIteratorIterable
• added doc comments explaining _WithIteratorIterable usage
• changed parameter construction to this._iteratorFactory

Verified the SDK compilation on my local machine

Verified the newly added test was passing

Verified by running an example using the locally compiled SDK

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[drxddy]

Hi @lrhn, I just made those white-space fixes and docs changes as you suggested in Gerrit, please merge if everything looks good.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/404341 has been updated with the latest commits from this pull request.

[drxddy]

Hey @lrhn, I did dart format for the newly added test file to pass the pre-submit try test, I couldn't restart that failed test myself (access restricted), I'm curious to know when you added the CL to commit-queue, does it automatically kick-off all the relevant tests?

[lrhn]

Yes, all I did was press the "commit" button. There is also a button to run tests without committing. The commit button only runs tests of the same patch hasn't already run the tests successfully.

[drxddy]

Got it @lrhn, are there any changes I need to make or can we merge it?

[drxddy]

Hey @lrhn, are there any changes required to merge this?