-
Couldn't load subscription status.
- Fork 1.7k
docs: add notice linking to analysis_server_plugin #61820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: add notice linking to analysis_server_plugin #61820
Conversation
|
@FMorschel can you review this plz? |
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/457580 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
Het @Hassnaa9 ! Thanks for helping out! The small nit I'd add here would be to separate the But unfortunately I'm not from the team and I can't review this for you. I can add reviewers on Gerrit though. I'll do that! |
|
Note that you'll need to close the issue manually after that CL lands. If you can ask a reviewer to change the description to contain |
|
https://dart-review.googlesource.com/c/sdk/+/457580 has been updated with the latest commits from this pull request. |
ok ,many thanks for you |
|
https://dart-review.googlesource.com/c/sdk/+/457580 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/457580 has been updated with the latest commits from this pull request. |
Title:
Fixes #61817
docs: add notice linking to analysis_server_pluginDescription:
This pull request updates the
pkg/analyzer_plugin/README.mdfile to include a note directing users to theanalysis_server_pluginpackage.The change clarifies where plugin developers should look for the maintained implementation and helps avoid confusion when exploring the analyzer plugin system.
Why:
Developers exploring the analyzer plugin system often miss the fact that the maintained plugin implementation has moved to
analysis_server_plugin.This update improves documentation clarity and developer onboarding.
Related issue:
Fixes [dart-lang/sdk#61817](#61817)
Contribution guidelines:
dart format.Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.