Skip to content

Conversation

@Hassnaa9
Copy link
Contributor

@Hassnaa9 Hassnaa9 commented Oct 25, 2025

Title:
Fixes #61817
docs: add notice linking to analysis_server_plugin

Description:
This pull request updates the pkg/analyzer_plugin/README.md file to include a note directing users to the analysis_server_plugin package.
The change clarifies where plugin developers should look for the maintained implementation and helps avoid confusion when exploring the analyzer plugin system.

Why:
Developers exploring the analyzer plugin system often miss the fact that the maintained plugin implementation has moved to analysis_server_plugin.
This update improves documentation clarity and developer onboarding.

Related issue:
Fixes [dart-lang/sdk#61817](#61817)


  • [x ] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

@Hassnaa9
Copy link
Contributor Author

@FMorschel can you review this plz?

@copybara-service
Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/457580

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@FMorschel
Copy link
Contributor

Het @Hassnaa9 ! Thanks for helping out!

The small nit I'd add here would be to separate the **Notice** line (one empty line before and one after). Only because Markdown sometimes can be a bit weird with new lines but other than that. I'd say it's good 😁!

But unfortunately I'm not from the team and I can't review this for you. I can add reviewers on Gerrit though. I'll do that!

@FMorschel
Copy link
Contributor

Note that you'll need to close the issue manually after that CL lands. If you can ask a reviewer to change the description to contain Fixes: <issue-url>, it may close the issue. Otherwise, it will, as stated there, close this PR and not merge it. The merging happens with Copybara somewhere else. And since this will not be merged, it doesn't close the linked issue.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/457580 has been updated with the latest commits from this pull request.

@Hassnaa9
Copy link
Contributor Author

Note that you'll need to close the issue manually after that CL lands. If you can ask a reviewer to change the description to contain Fixes: <issue-url>, it may close the issue. Otherwise, it will, as stated there, close this PR and not merge it. The merging happens with Copybara somewhere else. And since this will not be merged, it doesn't close the linked issue.

ok ,many thanks for you

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/457580 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/457580 has been updated with the latest commits from this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In analyzer_plugin README, **loudly** point to analysis_server_plugin

2 participants