Publish shelf_router_generator 1.1.1

[johnpryan]

I think it's OK to publish this version now.

cc/ @devoncarew @kevmoo

[devoncarew]

We'll need to rev the changelog version as well:

error: pubspec version (1.1.1) and changelog (1.1.1-wip) don't agree

[devoncarew]

It looks like the publish task is failing on a separate package:

  Package validation found the following potential issue:
  * The name of "lib/builder.dart", "builder", should match the name of the package, "shelf_router_generator".
    This helps users know what library to import.

I'll file an issue to address this.

[github-actions]

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:shelf_router_generator	1.1.1	ready to publish	shelf_router_generator-v1.1.1
package:shelf	1.4.3-wip	WIP (no publish necessary)
package:shelf_packages_handler	3.0.3-wip	WIP (no publish necessary)
package:shelf_proxy	1.0.5-wip	WIP (no publish necessary)
package:shelf_router	1.1.5-wip	WIP (no publish necessary)
package:shelf_static	1.1.3	already published at pub.dev
package:shelf_test_handler	2.0.3-wip	WIP (no publish necessary)
package:shelf_web_socket	3.0.0-wip	WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[johnpryan]

Can we merge without fixing the builder.dart filename?

[kevmoo]

It looks like the publish task is failing on a separate package:

  Package validation found the following potential issue:
  * The name of "lib/builder.dart", "builder", should match the name of the package, "shelf_router_generator".
    This helps users know what library to import.

I'll file an issue to address this.

This is a convention for builders we've had FOREVER. CC @jakemac53

not sure we want to teach pub about it, though....

[jakemac53]

This is a convention for builders we've had FOREVER. CC @jakemac53

not sure we want to teach pub about it, though....

My unpopular opinion is this is a horrible recommendation period 🤣 . We should be doing the opposite and encouraging packages to have many different imports instead of one huge one.

But, in general for this specific issue the builder.dart pattern makes a lot of sense and we shouldn't be changing it. These imports are typically only for builds scripts, not users. We could alter the pattern to move them under lib/src/....

[devoncarew]

I opened dart-lang/pub#4484 to remove or gain the ability to ignore this warning.