Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runTwice function for Dart 2.9 in DartPad samples on homepage #2581

Closed
johnpryan opened this issue Aug 14, 2020 · 2 comments · Fixed by #2683
Closed

Fix runTwice function for Dart 2.9 in DartPad samples on homepage #2581

johnpryan opened this issue Aug 14, 2020 · 2 comments · Fixed by #2683
Assignees
@johnpryan
Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work fix.examples Adds or changes example p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@johnpryan
Copy link
Contributor

Since #2574 was merged, we need to apply this change to the snippet in dartpad_picker_main.js:
@johnpryan johnpryan mentioned this issue Aug 14, 2020
Merged
@johnpryan johnpryan self-assigned this Aug 14, 2020
@kwalrath kwalrath added e0-minutes Can complete in < 60 minutes of normal, not dedicated, work fix.examples Adds or changes example p2-medium Necessary but not urgent concern. Resolve when possible. labels Aug 19, 2020
@kwalrath
Copy link
Contributor

I didn't notice you were assigned and tried to do this myself... ./compile[_dev].sh didn't work for me, though.

@johnpryan johnpryan mentioned this issue Oct 5, 2020
Merged
@johnpryan
Copy link
Contributor Author

The bash scripts both worked for me with Dart 2.9.2, do you have any console output?

I created a PR to address this issue: #2683

kwalrath pushed a commit that referenced this issue Oct 5, 2020
@johnpryan
Update dartpad_picker sample to include change to snippet (#2683)
fdb4a4a 
closes #2581
@kwalrath kwalrath mentioned this issue Oct 5, 2020
Closed
This was referenced Sep 16, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnpryan johnpryan

Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work fix.examples Adds or changes example p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dartpad_picker sample to include change to snippet
2 participants
@johnpryan @kwalrath