Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter SDK includes the full Dart SDK, as of 1.20 #2529

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Flutter SDK includes the full Dart SDK, as of 1.20 #2529

merged 2 commits into from
Jul 17, 2020

Conversation

@kwalrath kwalrath requested review from kevmoo and sfshaza2 July 17, 2020 13:38
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Jul 17, 2020
Copy link
Collaborator

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You can either download the Dart SDK directly
(as described below)
or [download the Flutter SDK,][]
which (as of Flutter 1.20) includes the Dart SDK.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This surprises me. I thought it was as of 1.17.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevmoo can you confirm the first version of Flutter that includes the full Dart SDK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new to me, too! @timsneath ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the full Dart SDK isn't in the Flutter SDK even in 1.20, since dart2native (e.g.) isn't in the Flutter SDK. Its functionality will be available when the expanded dart command is available, which looks like it'll be 1.21. I'm going to create a PR to undo the work of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I'm just changing 1.20 to 1.21. I hope that isn't too confusing. #2562

@sfshaza2 sfshaza2 merged commit 143bd73 into master Jul 17, 2020
@sfshaza2 sfshaza2 deleted the kw-sdk branch July 17, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants