Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce documentation for new strict modes #3823

Merged
merged 10 commits into from
Feb 11, 2022

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 8, 2022

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Visit the preview URL for this PR (updated for commit 03e2818):

https://dart-dev--pr3823-feature-document-new-rvn1lj8u.web.app

(expires Wed, 16 Feb 2022 21:27:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@parlough parlough force-pushed the feature/document-new-analysis-types branch from 668ccbc to 615a6aa Compare February 9, 2022 03:32
@parlough parlough force-pushed the feature/document-new-analysis-types branch from 615a6aa to 3297e9d Compare February 9, 2022 03:36
@parlough
Copy link
Member Author

parlough commented Feb 9, 2022

@srawlins Any feedback on good examples to use or other changes here? I wanted to include one illustrating example for each mode and their resulting errors/hints. Thanks!

@parlough parlough requested a review from srawlins February 9, 2022 21:24
@srawlins
Copy link
Member

Wow I love it!

@parlough parlough marked this pull request as ready for review February 10, 2022 23:04
@parlough parlough requested a review from sfshaza2 February 10, 2022 23:04
Copy link
Collaborator

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and, more importantly, @srawlins likes it!

@sfshaza2 sfshaza2 merged commit 81d3bf8 into main Feb 11, 2022
@parlough parlough deleted the feature/document-new-analysis-types branch February 11, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis options page should document strict modes
4 participants