Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for new dev analysis changes #4384

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Fix build for new dev analysis changes #4384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f350169
Fix build for new dev analysis changes
parlough Nov 17, 2022
b5d71bb
Make path exception version agnostic
parlough Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/analysis/analyzer-results-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Analyzing analysis...

error - lib/strict_modes.dart:15:7 - The argument type 'dynamic' can't be assigned to the parameter type 'List<String>'. - argument_type_not_assignable
info - lib/lint.dart:9:19 - Avoid empty statements. - empty_statements
info - lib/lint.dart:9:19 - Unnecessary empty statement. Try removing the empty statement or restructuring the code. - empty_statements
info - lib/lint.dart:17:7 - Close instances of `dart.core.Sink`. - close_sinks
info - lib/strict_modes.dart:22:17 - The type argument(s) of 'Map' can't be inferred. Use explicit type argument(s) for 'Map'. - inference_failure_on_collection_literal
info - lib/strict_modes.dart:33:3 - The generic type 'List<dynamic>' should have explicit type arguments but doesn't. Use explicit type arguments for 'List<dynamic>'. - strict_raw_type
Expand Down
1 change: 1 addition & 0 deletions examples/misc/lib/effective_dart/usage_bad.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
// ignore_for_file: avoid_function_literals_in_foreach_calls, prefer_function_declarations_over_variables
// ignore_for_file: prefer_adjacent_string_concatenation, prefer_is_not_empty, prefer_interpolation_to_compose_strings
// ignore_for_file: unnecessary_this, always_declare_return_types, no_leading_underscores_for_local_identifiers
// ignore_for_file: deprecated_colon_for_default_value
import 'dart:async';
import 'dart:io';
import 'dart:math';
Expand Down
2 changes: 1 addition & 1 deletion examples/misc/lib/effective_dart/usage_good.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// ignore_for_file: type_annotate_public_apis, unused_element, unused_local_variable
// ignore_for_file: prefer_function_declarations_over_variables, strict_raw_type,
// ignore_for_file: prefer_initializing_formals, prefer_typing_uninitialized_variables
// ignore_for_file: use_super_parameters
// ignore_for_file: use_super_parameters, dead_code
import 'dart:async';
import 'dart:io';
import 'dart:math';
Expand Down
2 changes: 1 addition & 1 deletion examples/misc/test/library_tour/io_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ void main() {
}

// #enddocregion try-catch
expect(main, prints(startsWith('FileSystemException')));
expect(main, prints(contains('Cannot open file')));
});

test('read-from-stream', () {
Expand Down