[2.19] Add runZonedGuarded to Zones page
#4403
Conversation
MaryaBelanger
changed the title
runZonedGuarded to Zones page
MaryaBelanger
changed the title
runZonedGuarded to Zones pagerunZonedGuarded to Zones page
|
Visit the preview URL for this PR (updated for commit 0fc00a6): https://dart-dev--pr4403-zones-onerror-0aw72vy3.web.app (expires Wed, 21 Dec 2022 05:06:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
|
You're right, the code examples aren't currently linked to anything or tested. I'm assuming some of them don't even compile anymore or are incorrect. Adjusting the code in the Markdown should be sufficient for this change. I haven't had a chance to add code excerpts yet but I'm tracking the work in #4348. If you want me to prioritize the code excerpts, updating the code, and testing, let me know. |
There was a problem hiding this comment.
@MaryaBelanger : I noted some readability issues. Have a look. I leave most as suggestions in that what I added is a possibility, but consider working with the language in each comment.
Unrelated to the actual topic. but wondering about this. @parlough I don't think I explicitly deployed to a firebase project of mine, does this just happen automatically? |
|
@MaryaBelanger If the build and tests pass, changes on a branch of dart-lang/site-www will be automatically staged on a temporary Firebase preview channel. Helps you avoid having to rebuild and deploy for every commit and makes it so some contributors don't necessarily need a local setup, which can be cumbersome. |
There was a problem hiding this comment.
@MaryaBelanger : Solid content! Just needs some tightening. I explain why instead of just offering alternatives. See what you think?
There was a problem hiding this comment.
@MaryaBelanger : Great work and great points! I updated with a few questions and comments.
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
This page obviously needs a lot of work, so I didn't update any of the conceptual content or any other dart syntax stuff _except_ what is directly related to changing the examples to using `runZonedGuarded`. Full page update is tracked here: #4348 Closes #4224 Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>
This page obviously needs a lot of work, so I didn't update any of the conceptual content or any other dart syntax stuff _except_ what is directly related to changing the examples to using `runZonedGuarded`. Full page update is tracked here: #4348 Closes #4224 Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>
This page obviously needs a lot of work, so I didn't update any of the conceptual content or any other dart syntax stuff _except_ what is directly related to changing the examples to using `runZonedGuarded`. Full page update is tracked here: #4348 Closes #4224 Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>
This page obviously needs a lot of work, so I didn't update any of the conceptual content or any other dart syntax stuff _except_ what is directly related to changing the examples to using `runZonedGuarded`. Full page update is tracked here: #4348 Closes #4224 Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>
This page obviously needs a lot of work, so I didn't update any of the conceptual content or any other dart syntax stuff except what is directly related to changing the examples to using
runZonedGuarded.Full page update is tracked here: #4348
Closes #4224