-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dart 3] Class modifiers #4754
[Dart 3] Class modifiers #4754
Conversation
Visit the preview URL for this PR (updated for commit 155c81c): https://dart-dev--pr4754-class-modifiers-60un2t0u.web.app (expires Mon, 15 May 2023 18:42:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of extra comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaryaBelanger : Solid work. Issues are:
I provided suggestions throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update! A few issues, suggestions, and nits. Handle the issues and no need for another pass.
Reviewers:
abstract
" section (didn't update text) hereUpdates in progress after first review:
extends
,implements
, etc is failing is clearly NOT in the same library where the modified class is declared.TODO (possibly separate PRs):
/language/class-modifiers#sealed
, need to change link on "exhaustiveness checking" to actual section once that's writtenFixes #4497
Fixes #4662
Fixes #4581