Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move language and library tour to deprecated folder #6259

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Dec 7, 2024

Contributes to #5767

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit ef4a1cb):

https://dart-dev--pr6259-feat-move-tours-to-deprected-folder-tw3vd4q8.web.app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these /deprecated/... destinations just redirect to the new version of the page?

I end up at /language and /libraries when testing the old source for each. I think I see it jump to /deprecated first though. Just checking that that's the intended behavior

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's the intended behavior if you don't specify any fragment (#id).

It's been a while since we implemented this, but remember we set up client-based redirects to redirect from a fragment to the correct location. As different fragments should lead to different pages, but the server doesn't see the fragments.

For example, /guides/language/language-tour#enums will redirect to /deprecated/language-tour#enums, then the JS on that page will look at the fragment and redirect to /language/enums.

@parlough parlough merged commit 65885e1 into main Dec 10, 2024
10 checks passed
@parlough parlough deleted the feat/move-tours-to-deprected-folder branch December 10, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants