Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move language and library tour to deprecated folder #6259

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Move language and library tour to deprecated folder #6259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions firebase.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these /deprecated/... destinations just redirect to the new version of the page?

I end up at /language and /libraries when testing the old source for each. I think I see it jump to /deprecated first though. Just checking that that's the intended behavior

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's the intended behavior if you don't specify any fragment (#id).

It's been a while since we implemented this, but remember we set up client-based redirects to redirect from a fragment to the correct location. As different fragments should lead to different pages, but the server doesn't see the fragments.

For example, /guides/language/language-tour#enums will redirect to /deprecated/language-tour#enums, then the JS on that page will look at the fragment and redirect to /language/enums.

Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@
{ "source": "/guides/language/effective-dart/:page*", "destination": "/effective-dart/:page*", "type": 301 },
{ "source": "/guides/language/extension-methods", "destination": "/language/extension-methods", "type": 301 },
{ "source": "/guides/language/formatting", "destination": "/tools/dart-format", "type": 301 },
{ "source": "/guides/language/language-tour", "destination": "/deprecated/language-tour", "type": 301 },
{ "source": "/guides/language/library-tour", "destination": "/libraries", "type": 301 },
{ "source": "/guides/language/sound-dart", "destination": "/language/type-system", "type": 301 },
{ "source": "/guides/language/sound-faq", "destination": "/language/type-system", "type": 301 },
Expand All @@ -232,6 +233,7 @@
{ "source": "/guides/libraries/create-library-packages", "destination": "/guides/libraries/create-packages", "type": 301 },
{ "source": "/guides/libraries/futures-error-handling", "destination": "/libraries/async/futures-error-handling", "type": 301 },
{ "source": "/guides/libraries/java-interop", "destination": "/interop/java-interop", "type": 301 },
{ "source": "/guides/libraries/library-tour", "destination": "/deprecated/library-tour", "type": 301 },
{ "source": "/guides/libraries/objective-c-interop", "destination": "/interop/objective-c-interop", "type": 301 },
{ "source": "/guides/libraries/c-interop", "destination": "/interop/c-interop", "type": 301 },
{ "source": "/guides/libraries/writing-package-pages", "destination": "/tools/pub/writing-package-pages", "type": 301 },
Expand Down
5 changes: 3 additions & 2 deletions src/content/guides/language/language-tour.md → src/content/deprecated/language-tour.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
---
title: A tour of the Dart language
description: A tour of all the major Dart language features.
title: Deprecated tour of the Dart language
description: The previous destination of the Dart language tour.
short-title: Language tour
js: [{url: '/assets/js/language-tour-redirector.js'}]
sitemap: false
canonical: https://dart.dev/language
noindex: true
skipFreshness: true
show_breadcrumbs: false
---

:::warning
Expand Down
5 changes: 3 additions & 2 deletions src/content/guides/libraries/library-tour.md → src/content/deprecated/library-tour.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
---
title: A tour of the core libraries
description: Learn about the major features in Dart's libraries.
title: Deprecated tour of the core libraries
description: The previous destination of the Dart core library introduction.
short-title: Library tour
js: [{url: '/assets/js/library-tour-redirector.js'}]
sitemap: false
canonical: https://dart.dev/libraries
noindex: true
skipFreshness: true
show_breadcrumbs: false
---

:::warning
Expand Down
Loading